Rocket.Chat.Electron
Rocket.Chat.Electron copied to clipboard
Feature request: Tray icon should blink if new PM received
My Setup
- My OS name and version: Windows 7 64.bit
- My current app version: 2.8.0
- [x] I have tested with the latest application version
- [x] I can simulate the issue easily
Description
Current Behavior
If you receive a PM, the tray icon is changed to red icon with an unread number indicator.
Expected Behavior
It would be helpful, that in case of new PM the tray icon is blinking. Either as default or as option.
I tested this on Windows 7, and it seems to work as expected, unless you are talking about something else? Do you have any settings enabled to disable notifications for direct messages?
You talk about the app Icon. I mean the tray icon. In our installation, many people overlook a new PM.
@johntq I don't think its possible to make the tray icon blink on windows. We could potentially change the colour if that would help?
Hmm. Another idea: It is possible to have an option wich can set the tool tip timout to endless or open the main window in case of new PM?
Why you cant make the icon blink?
If you can change image - you can "blink"
Just change images
@alexbrazier I will explain the motivation behind my request.
Our company is evaluating the transition from Jabber protocol based client to Rocket.Chat.
Now we are in the testing phase. Many participant have reported, that noone notice a new PM. Some percent of our Instant Messaging are real time information, such as come over or pizza is arrived. Meanwhile, some have starved to death because they have not noticed their PM.
For us it is very important that you can notice new PM better.
I have a similar issue/feature request. We have users also missing PMs because they miss the few seconds that the pop-up notification appears. Ideally, I would like it if the pop-up notification of a new message stays on the screen until clicked or dismissed. I have seen this with other IM clients, do you think this would be possible to add to Rocket.Chat?
isn't the same issue as https://github.com/RocketChat/Rocket.Chat.Electron/issues/487? If so, we can close one of them!
@geekgonecrazy
It looks like the same. Important: I am talking about the tray icon, not the task bar icon.
sure! the other issue is also about the tray icon :smile:
I'm in the process of reviewing your app for our organization. Having the Tray Icon blink when a message arrives is a key feature for our member experience. leaving the app open on the task bar is not an option for us at this time. Am I correct that no one is working on this feature or am I missing the setting in preferences?
I made a very simple change to implement a blinking tray icon:
https://github.com/RocketChat/Rocket.Chat.Electron/compare/develop...iplabs:feature/blinking-tray-icon
When an alert tray icon is to be displayed then it blinks (Toggling between normal tray icon and the requested alert tray icon every 500ms). When a non-alert tray icon (normal or unread) is displayed then it does not blink.
Works pretty well here but I'm not sure if it is ready for a pull request yet, because there are some open questions:
- Is it ok to hardcode the blinking because everyone will benefit from it? Or is it better to make it configurable?
- If it must be configurable then what is the correct place for the new config? Server-side like the "Unread Tray Icon Alert" config? Or client-side like the "Toggle Menu Bar" setting?
- I only changed the behaviour for Windows/Linux but what about OSX? Do Mac users need a blinking icon? Or is the OSX-builtin message counter on the app icon already notifying enough?
If you want to try the blinking without compiling your own client then you can locate the app.asar
file in your Rocket.Chat installation, unpack it somewhere, patch the unpacked content with blink.diff.txt, repack the asar file and replace the original one with it.
When you click the close button on the windows bar after that icon does not turn orange.
View > Tray Icon to Disable
but, when click em close button of program
If you want to try the blinking without compiling your own client then you can locate the
app.asar
file in your Rocket.Chat installation, unpack it somewhere, patch the unpacked content with blink.diff.txt, repack the asar file and replace the original one with it.
Seems like this patch no longer works with the current Rocket.Chat 2.15.3 as the code looks like it's been refactored at some point. Did you ever update your patch for this latest version?
this should be must have feature!!
I was trying to resolve this issue so, when I tried to check for the issue, I found that when ever some one gets a notification , there's no change in the tray icon , so after looking upon the notification folder , I found out that tray icons must be integrated with the notification folder. This is the possible solution that I can come with. So, can I proceed with the solution.
Hey There,
This issue is already present in the current version of Rocket Chat ( 3.8.9 ), both flashframe
and dockbounce
works if any PM comes to the app.
Kindly update to the latest version & consider closing the issue. Thanks! 😊
Hello, we will be tracking the blinking icon feature request here: https://github.com/RocketChat/Rocket.Chat.Electron/issues/2525 I will be closing this issue because there are duplicated ones.