Rocket.Chat.Electron icon indicating copy to clipboard operation
Rocket.Chat.Electron copied to clipboard

fix: Issues in German translation

Open Phoenix616 opened this issue 1 month ago • 2 comments

This fixes some issues in the German translation:

  • The "back" button in the menu was translated with the German word for the body part "back" instead of the one for "going backwards"
  • Grammatical error in the XSS warning message
  • Fix non-full German translation in unreadMention_plural

Summary by CodeRabbit

  • Chores
    • Updated German language translations for improved messaging accuracy and consistency throughout the user interface, including refinements to menu labels, notification text, and descriptive content.

✏️ Tip: You can customize this high-level summary in your review settings.

Phoenix616 avatar Dec 06 '25 15:12 Phoenix616

Walkthrough

German language translation file updated with corrections and improvements. Menu back button translation revised, self-XSS description reworded for clarity, and unread mention notifications translated from English to German.

Changes

Cohort / File(s) Summary
German Localization Updates
src/i18n/de-DE.i18n.json
Updated German translations: menu back button ("&Der Rücken" → "&Zurück"), self-XSS description reworded with corrected quoting, and unread mention/direct message plural tooltip translated to German. Trailing whitespace adjusted.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Translation strings are straightforward text updates with no logic changes
  • Single file modification makes scope minimal
  • Verify translations are accurate German and context-appropriate
  • Confirm template variables (e.g., {{- count}}) remain intact in tooltip strings

Poem

🐰 A rabbit hops through languages bright, German words now perfectly right, From "&Der Rücken" to "&Zurück" we spring, Translations polished—a localization thing! 🌍✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: fixing issues in German translations across multiple keys (menu back button, XSS message, and unread mentions).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Dec 06 '25 15:12 coderabbitai[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Dec 06 '25 16:12 CLAassistant