Rocket.Chat.Electron icon indicating copy to clipboard operation
Rocket.Chat.Electron copied to clipboard

Screen share does not work on RocketChat Electron

Open moell9 opened this issue 10 months ago • 43 comments

Search before asking

  • [x] I had searched in the issues and found no similar issues.

Operating System

  • [x] macOS
  • [x] Windows
  • [x] Linux

Operating System Version

No response

It happens on the web browser too?

No, it just happens on the Desktop app

Rocket.Chat Desktop App Version

4.1.2

Rocket.Chat Server Version

7.3.1

Describe the bug

Please see here: https://github.com/RocketChat/Rocket.Chat/issues/35110

How to Reproduce

Just try to share a screen or a window.

Describe your Expected behavior

No response

Anything else

No response

Are you willing to submit a code contribution?

  • [ ] Yes, I am willing to submit a Pull Request!

moell9 avatar Feb 19 '25 09:02 moell9

You state in https://github.com/RocketChat/Rocket.Chat/issues/35110

We disabled Open Video Chat using Application Window. And then in Chrome we can share the screen or a window.

And according to this it looks like it needs an update to the underlying Electron SDK, and Jitsi itself. So it's going to be a while before you get a fix and you have a workaround for now.

https://github.com/jitsi/jitsi-meet/issues/15574#issuecomment-2668092458

I'll ask the team for comments.

reetp avatar Feb 19 '25 10:02 reetp

According to the latest answer in https://github.com/jitsi/jitsi-meet/issues/15574#issuecomment-2668092458, it should be fixed by updating the Electron SDK to version 7.

friedrichkeydel avatar Mar 03 '25 22:03 friedrichkeydel

Does anyone from the staff of rocketchat knows, when this will be fixed on the Rocketchat Clients? We have a paid subscription, would be nice, if it could work again. Thanks

rgoerner avatar Mar 04 '25 11:03 rgoerner

Does anyone from the staff of rocketchat knows, when this will be fixed on the Rocketchat Clients?

When it gets done. It has to go through multiple layers and departments and I would expect it normally would take a couple of release cycles at least, depending on other priorities.

We have a paid subscription, would be nice, if it could work again. Thanks

In which case you should use the correct channel which is support, and raise an issue there. You can quote this Issue as a reference.

Note that Github is really just the released end product. It is not the primary source of code or issues for Rocket. That is what paid support and the ticketing system is for.

reetp avatar Mar 04 '25 12:03 reetp

The new update is frustrating, sorry to say this.

moell9 avatar Mar 07 '25 08:03 moell9

I'm in contact with people from Jitsi. They say and ask: There is a fallback mechanism that should kick in. What Electron SDK and Jitsi Meet versions do they use?

moell9 avatar Mar 07 '25 09:03 moell9

👋 Hey there Saúl from Jitsi here.

Looks like RocketChat is not using the Jitsi Electron SDK (https://github.com/jitsi/jitsi-meet-electron-sdk) but rather including the piece of code that made screen-sharing work directly.

This had the unfortunate consequence of RC missing on the SDK updates that migrated the way to do this "the right way".

We are on the 3rd (and hopefully final, since we are now using getDisplayMedia, like browsers) of screen-sharing.

RC currently implements the old-old mechanis, which we dropped after we added the latest one. We still keep compatibility with the old one, but not with the old-old one that required injecting a global in the render process.

In both the old and the new the mechanism relies on the external API for signalling the sources.

I'd suggest using the SDK so you can get these updates going forward.

Cheers!

saghul avatar Mar 07 '25 11:03 saghul

Can we expect a change here in the foreseeable future, as Saúl has suggested?

moell9 avatar Mar 10 '25 13:03 moell9

@saghul there is a way to make it work as we had without using the whole SDK installed? Before was easy to maintain and fix.

jeanfbrito avatar Mar 10 '25 13:03 jeanfbrito

@moell9 We definitely want to make it work, but we need to keep it maintainable.

jeanfbrito avatar Mar 10 '25 13:03 jeanfbrito

@saghul I need a direct contact with Jitsi maintainers, may be with you? May be by email? I don't know. I really want to align the jitsi support for the future and we are missing a lot of changes that we just notice when it breaks and need to fix it. Can you share a way to we talk directly? I'm the Desktop app maintainer from Rocket chat.

jeanfbrito avatar Mar 10 '25 13:03 jeanfbrito

Hey @jeanfbrito happy to chat! you can email me at: my-gh-username @ jitsi dot org.

saghul avatar Mar 10 '25 13:03 saghul

For a customer, like me, this is not nice to read and quite weired. Rocketchat as a commercial provider (we pay for it) does not have a correctly working SDK integration which is quite usual. And then, they begin in this public chat to exchange contact details after several years this integration was released. Now, we have the Windows Client 4.2.0 with a "workaround" to open all in a Browser. This is then, a client? Why, do we then need a client? We pay 600 $ a month on all this, and what do we receive? Upgrade to V7 was rolled out with changing in policies, so that you NEED a paid Enterprise subscription to use Jitsi, and then, this is not even correctly in place. Poor!

rgoerner avatar Mar 10 '25 16:03 rgoerner

@rgoerner we don't sell Jitsi. Jitsi changed. If you have any concerns about it please contact our support and we will help you.

jeanfbrito avatar Mar 10 '25 18:03 jeanfbrito

Upgrade to V7 was rolled out with changing in policies, so that you NEED a paid Enterprise subscription to use Jitsi, and then, this is not even correctly in place. Poor!

Please clarify this. What do you need Enterprise to use Jitsi? It should work in Community Edition.

jeanfbrito avatar Mar 10 '25 18:03 jeanfbrito

so that you NEED a paid Enterprise subscription to use Jitsi

As a correction no, you do not.

We run it on starter and CE but don't use the client for calls.

We also run our own Jitsi - which is not part of Rocket.Chat

But you can use meet.jit.si

The jitsi marketplace app is just a plugin to enable slash commands etc.

reetp avatar Mar 10 '25 19:03 reetp

@jeanfbrito you spoke already to @saghul ? If so, can we expect another update with the Jitsi integration?

moell9 avatar Mar 12 '25 10:03 moell9

Please, be patient.

We haven't had a chance to talk yet.

saghul avatar Mar 12 '25 13:03 saghul

I do not check and understand the problem. Sorry. It is quite usual to integrate a third party solution using a SDK...

rgoerner avatar Mar 12 '25 14:03 rgoerner

Sorry to ask again. Is there any progress? I think a lot of people are waiting for Jitsi Meet to be able to be used in the Rocket Chat Application Window again and also be able to share their desktop screen.

moell9 avatar Mar 25 '25 14:03 moell9

@moell9 you can test this PR artifacts that are on comments https://github.com/RocketChat/Rocket.Chat.Electron/pull/3006

jeanfbrito avatar Mar 25 '25 16:03 jeanfbrito

@jeanfbrito thank you first for the answer. We tested this PR artifacts on Windows and macOS. It's running perfectly from our view. The share in the application window is possible again. Have you integrated the Jitsi Meet SDK ?

moell9 avatar Mar 26 '25 08:03 moell9

Thank you for providing the new version 4.3. Today I also had the opportunity to test it under (Debian) Linux. There is a problem with sharing the desktop. It is not clear why a permission must be released here. There is no such setting under Debian Linux.

Image

moell9 avatar Mar 27 '25 09:03 moell9

@moell9 what Debian version exactly? I will need to take a look.

jeanfbrito avatar Mar 27 '25 13:03 jeanfbrito

Thank you for providing the new version 4.3. Today I also had the opportunity to test it under (Debian) Linux. There is a problem with sharing the desktop. It is not clear why a permission must be released here. There is no such setting under Debian Linux.

Image

Same for me on Fedora 41 with X11 and RPM.

TimmiORG avatar Mar 27 '25 13:03 TimmiORG

I have on the latest Debian 12.

moell9 avatar Mar 27 '25 13:03 moell9

Something else we noticed now, RocketChat cannot be installed under macOS 10.x. Are the requirements available somewhere?

moell9 avatar Mar 28 '25 09:03 moell9

Something else we noticed now, RocketChat cannot be installed under macOS 10.x. Are the requirements available somewhere?

Image

Well, maybe you should use a OS with valid support hm ;)

rgoerner avatar Mar 28 '25 09:03 rgoerner

Oh, this must be Electron builder that don't create the installer for them anymore. Because any Apple thing needs to be authorized by their servers, so is possible that even if the try create it would not be signed.

jeanfbrito avatar Mar 28 '25 13:03 jeanfbrito

Any news on the Linux problem with the permission ?

moell9 avatar Apr 08 '25 09:04 moell9