Rocket.Chat.Electron icon indicating copy to clipboard operation
Rocket.Chat.Electron copied to clipboard

Download and Settings in Light Theme when operating on Dark Theme

Open aadarsh-nagrath opened this issue 1 year ago • 3 comments

Is your feature request related to a problem? Please describe. Why is Settings and Download section so light in theme even when I am operating on Dark Theme. image image image

Describe the solution you'd like Download and Settings should be Dark Themed when in dark mode and light when in light mode.

Describe alternatives you've considered None

Additional context Both section themes should match with corresponding selected theme.

aadarsh-nagrath avatar Oct 13 '23 18:10 aadarsh-nagrath

I want to work on this issue, can it be assigned to me?

Yashraj7890 avatar Oct 15 '23 21:10 Yashraj7890

Reason

This happens because backgroundColor has set to white in C:\Users\aryan\Desktop\GSOC2024\rocketChat\Rocket.Chat.Electron\src\ui\components\DownloadsManagerView\index.tsx same goes for the settings.

Solution

all you have to do is, put ternary and toggle it with current theme mode.

To fix

I can fix it if its required.

thank you

aryanpnd avatar Dec 31 '23 13:12 aryanpnd

Soon it will be implemented, we are waiting for the fuselage team to add the dark mode inside it.

jeanfbrito avatar Feb 09 '24 18:02 jeanfbrito