Rocket.Chat.Electron icon indicating copy to clipboard operation
Rocket.Chat.Electron copied to clipboard

Clear up versioning/tags confusion

Open nicoroeser opened this issue 1 year ago • 0 comments

Search before asking

  • [X] I had searched in the issues and found no similar issues.

Operating System

  • [ ] macOS
  • [ ] Windows
  • [ ] Linux

Operating System Version

No response

It happens on the web browser too?

No, it just happens on the Desktop app

Rocket.Chat Desktop App Version

3.8.17

Rocket.Chat Server Version

any

Describe the bug

Tag 3.8.19 precedes tag 3.8.17. The version in package.json has respective changes.

Can be seen when regularly pulling the master branch, and may cause a bit of confusion or possibly problems.

The releases page offers a link to view the “Full Changelog” from 3.8.19 to 3.8.17. The changes from 3.8.16 to 3.8.19 are not included there.

The order of tags is unexpected (not good if they are meant to have semantic value).

How to Reproduce

Execute git log master or git log 3.8.17 or git log 3.8.19..3.8.17 or the like. Also visit the releases page. See the list of tags.

Describe your Expected behavior

Version numbers and tags should not decrease (when on the same branch at least).

Anything else

I would suggest to release 3.8.20 (with a short explanation in the release notes; maybe even without functional changes) in order to sort this out.

I advise against releasing another 3.8.19 as that would probably be ambiguous.

I understand that tag 3.8.19 does not appear on the releases page, but still it is in the tags, and especially in package.json (though we can argument that the latter has not been officially released so this is fine).

Are you willing to submit a code contribution?

  • [ ] Yes, I am willing to submit a Pull Request!

nicoroeser avatar Mar 21 '23 07:03 nicoroeser