Rocket.Chat.Electron icon indicating copy to clipboard operation
Rocket.Chat.Electron copied to clipboard

Published 20 hours ago • verified publisher icon RocketChat

feat: toggle dock bounce added for OSX alerts

Open Palanikannan1437 opened this issue 1 year ago • 0 comments

Closes Issue #2463

Issue in brief

User was not able to toggle off Dock Bounce in OSX platform for badge alerts, since Flash Frame is not an OSX specific feature which was specified in the settings earlier.

Suggested Fixes/Changes

  1. Enable Flash Frame toggle changed to Toggle Dock Bounce on alert and the description is changed accordingly
  2. Added a constraint for Flash Frame for OSX, since Flash Frame is not an OSX specific feature

Suggested Settings window on OSX:

image

Palanikannan1437 avatar Aug 10 '22 04:08 Palanikannan1437

@jeanfbrito It'd be awesome if you could review these changes and let me know if I need to make any more changes to my PR

Palanikannan1437 avatar Aug 10 '22 17:08 Palanikannan1437

Nice contribution @Palanikannan1437. We will merge it soon. Please take a look on the review. Just a simple thing.

jeanfbrito avatar Aug 15 '22 15:08 jeanfbrito

Nice contribution @Palanikannan1437. We will merge it soon. Please take a look on the review. Just a simple thing.

Hey there!! Thank you so much @jeanfbrito, I am not able to see any reviews yet on GitHub though.

image

This is what you meant by reviews right, or did I misunderstand you?

Palanikannan1437 avatar Aug 15 '22 15:08 Palanikannan1437

I forgot to publish it. Now is showing.

jeanfbrito avatar Aug 15 '22 16:08 jeanfbrito