Rocket.Chat.Electron icon indicating copy to clipboard operation
Rocket.Chat.Electron copied to clipboard

Published 20 hours ago • verified publisher icon RocketChat

feat: Make system tray icon blink upon messages received

Open radiokang opened this issue 2 years ago • 4 comments

Closes #452

Make the system tray icon blink and remove the number/dot badge on the icon v3r7cMnidt .

radiokang avatar Jan 31 '22 12:01 radiokang

@radiokang please fix the lint issues

jeanfbrito avatar Jan 31 '22 13:01 jeanfbrito

Hello @radiokang, thanks for your contribuition. I just reviewed it and have found this:

On Mac we have a number showing the unread messages. (left is yours icon, right is the original) image

On Windows, we used the icon to show that number, you removed it. (left is yours icon, right is the original) image

Would be interesting to keep the original icons and just add the hidden ones and change the states. Keeping the original ones untouched. I don't see the necessity to change the icons that our users are used to.

jeanfbrito avatar Feb 02 '22 17:02 jeanfbrito

Thanks for your suggestion. However, IMHO, I think it's enough to hint that there are new messages by blinking the icon. And it could be too much if there are two changes to a single icon at the same time (both blinking and adding a number/badge). Maybe we can wait for a while to see if there are any other suggestions :)

radiokang avatar Feb 03 '22 23:02 radiokang

Good, then @ggazzo will tell us if we will accept the change.

jeanfbrito avatar Feb 03 '22 23:02 jeanfbrito