Rocket.Chat.Electron icon indicating copy to clipboard operation
Rocket.Chat.Electron copied to clipboard

[Feature Request] Better menu integration in OSX

Open p10n opened this issue 4 years ago • 14 comments

My Setup

  • My Operation System: OSX 10.14.6
  • App Version: 2.17.9
  • Installation type: App Store
  • [x] I have tested with the latest version
  • [x] I can simulate the issue easily

Description

1.) If the RocketChat window is open, but hidden below other windows (or on a different workspace), the mini "rocket" menu (wich I much appreciate) still only shows "Hide" and "Quit". I would love to see "Show" on the top as well, which would just bring it to front and give it the focus. 2.) On OSX, all apps show their settings by pressing cmd-, (cmd + comma). I think RocketChat should show my preferences on that hotkey.

p10n avatar Mar 27 '20 11:03 p10n

Forgive if I have misunderstood what your suggestion is but I have some questions and suggestions.

For the first suggestion that you made. No separate menu button is usually needed as you may simply bring the app on top of other windows and into focus by clicking on the app icon in your Bottom App Tray? Whether it is in opened in your workspace along with other windows or open in a different workspace. Clicking the icon:

Screenshot 2020-04-21 at 12 47 19 AM Does exactly the thing you are currently asking for. Could you please elaborate on how what you have asked for is different or helps the user in a different way?

TaimurAzhar avatar Apr 20 '20 19:04 TaimurAzhar

Of course you are right, clicking on the icon in the Dock would do what I need. However, I found the small Rocket menu very convenient for bringing up the app window.

I think that the menu (once it is there already) would be a convenient place to allow access to the app window. If the menu allows to quit, I dont see a reason why it should not allow to access the app.

My idea was: In that specific situation (the Rocket window is open, but buried behind other windows), the Rocket menu has the options "Hide" and "Quit". I am not sure if many people would look for "Hide" in this situation, so my suggestion would be to provide "Show" instead of "Hide".

In other words, only provide "Hide" if the window is open AND has focus.

But, YMMV :-)

Cheers, Philipp

Am 20.04.20 um 21:52 schrieb Taimur Azhar:

Forgive if I have misunderstood what your suggestion is but I have some questions and suggestions.

For the first suggestion that you made. No separate menu button is usually needed as you may simply bring the app on top of other windows and into focus by clicking on the app icon in your App Tray? Whether it is in opened in your workspace along with other windows or open in a different workspace. Clicking the icon:

Screenshot 2020-04-21 at 12 47 19 AM https://user-images.githubusercontent.com/30270349/79793487-188eb880-836a-11ea-86ae-76c169d59f28.png

Does exactly the thing you are currently asking for. Could you please elaborate on how what you have asked for is different or helps the user in a different way?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/RocketChat/Rocket.Chat.Electron/issues/1564#issuecomment-616773173, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABI4HPDVAI5JKLS24KUTTNTRNSRXPANCNFSM4LU5VLDA.

-- DI Philipp Prause - Tel. +43 676 3058899

p10n avatar Apr 22 '20 10:04 p10n

It's true that one can use the dock shortcut to bring the app to view, but I also think a Show/Hide toggle would be really helpful for the menu bar status indicator. Here's a screenshot, so we are on the same page

image

philshem avatar May 05 '20 06:05 philshem

2.) On OSX, all apps show their settings by pressing cmd-, (cmd + comma). I think RocketChat should show my preferences on that hotkey.

Would it make sense to move this suggestion to a separate issue? I fear that it might get lost along the discussion here and I'm one who vouches a lot for consistency within a platform so fixing the missing cmd-comma shortcut is an important issue for me.

Feuermurmel avatar Jun 04 '20 11:06 Feuermurmel

Please test if the latest release did solve this. If not please reopen the issue or create a new one and tell us. I will be closing this one for now.

Thank you!

jeanfbrito avatar Jan 12 '22 01:01 jeanfbrito

I am using the current version from the OSX App Store, which is 3.0.3, and I don't see any change for 1.) as well as 2.) . I wonder whether I am missing something?

As @Feuermurmel suggested, I will create a separate issue for 2.) - edit: #2285

p10n avatar Jan 12 '22 09:01 p10n

I am using the current version from the OSX App Store, which is 3.0.3, and I don't see any change for 1.) as well as 2.) . I wonder whether I am missing something?

As @Feuermurmel suggested, I will create a separate issue for 2.) - edit: #2285

Sorry, the App store is outdated. We are working to make it updated again. Could you install the lastest version using the Github releases or wait a while. But is being worked right now.

jeanfbrito avatar Jan 12 '22 12:01 jeanfbrito

My App (from the AppStore) is now showing version 3.8.0. I am seeing no changes, neither regarding the menu nor regarding the settings hotkey. The settings hotkey is currently cmd-l, which is more than unusual. Besides, after opening the settings, there is no way back other than choosing "window -> Chat". I would expect either to be able to close the settings window (cmd-w), or have a button to get back to the main window.

p10n avatar Apr 05 '22 13:04 p10n

My App (from the AppStore) is now showing version 3.8.0. I am seeing no changes, neither regarding the menu nor regarding the settings hotkey. The settings hotkey is currently cmd-l, which is more than unusual. Besides, after opening the settings, there is no way back other than choosing "window -> Chat". I would expect either to be able to close the settings window (cmd-w), or have a button to get back to the main window.

I didn't get what is your problem. Could you be more specific?

jeanfbrito avatar Apr 05 '22 13:04 jeanfbrito

It is exactly 1.) and 2.) in the Description of this ticket.

p10n avatar Apr 05 '22 15:04 p10n

It is exactly 1.) and 2.) in the Description of this ticket.

This is a feature request then.

jeanfbrito avatar Apr 05 '22 15:04 jeanfbrito

My App (from the AppStore) is now showing version 3.8.0. I am seeing no changes, neither regarding the menu nor regarding the settings hotkey. The settings hotkey is currently cmd-l, which is more than unusual. Besides, after opening the settings, there is no way back other than choosing "window -> Chat". I would expect either to be able to close the settings window (cmd-w), or have a button to get back to the main window.

We didn't say that we have done your requests on this version my friend.

jeanfbrito avatar Apr 05 '22 15:04 jeanfbrito

You have asked me to test again on the latest release - so I was assuming that you either did some improvements or knew that the issues have already been adressed...

p10n avatar Apr 05 '22 20:04 p10n

I will take a look on your requests soon. Crossed fingers

Em ter., 5 de abr. de 2022 17:23, Philipp @.***> escreveu:

You have asked me to test again on the latest release - so I was assuming that you either did some improvements or knew that the issues have already been adressed...

— Reply to this email directly, view it on GitHub https://github.com/RocketChat/Rocket.Chat.Electron/issues/1564#issuecomment-1089294261, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI7PCTSNPRYVM2GRTB6FW3VDSOKZANCNFSM4LU5VLDA . You are receiving this because you modified the open/close state.Message ID: @.***>

jeanfbrito avatar Apr 05 '22 20:04 jeanfbrito