Rocket.Chat.Apps-engine icon indicating copy to clipboard operation
Rocket.Chat.Apps-engine copied to clipboard

`messageUpdater` is declared but never set

Open rezemble opened this issue 8 months ago • 3 comments

In src/server/accessors/ModifyUpdater.ts, the property private messageUpdater: IMessageUpdater; is declared and can be accessed through public getMessageUpdater(): IMessageUpdater but is never initialized. No actual implementation exists. Is there an open Issue to track the implementation? At either rate - as long as it is not implemented, I would suggest throwing an appropriate Error (Not implemented) or similar in the getter to avoid confusion and hours of debugging.

In the server logs, this just shows as a pretty non-descriptive error:

JSON-RPC error received: JsonRpcError {
  message: 'Internal error',
  code: -32603,
  data: {
    message: 'c.getMessageUpdater is not a function',
    logs: {
      appId: 'a8923afc-9b11-4caf-9ba3-cf1bee5498ca',
      method: 'app:executePostMessageSent',
      entries: [Array],
      startTime: 2025-04-17T13:12:01.384Z,
      endTime: 2025-04-17T13:12:01.408Z,
      totalTime: 24,
      _createdAt: 2025-04-17T13:12:01.408Z,
      instanceId: '6e30784a-252e-40f0-a74a-2137bc1f610e'
    }
  }
}

rezemble avatar Apr 17 '25 13:04 rezemble

It seems #792 added the code in question but failed to actually implement anything, but the issue is closed without comment

rezemble avatar Apr 17 '25 13:04 rezemble

"Hi , I'm Anjali Yadav, a MERN-stack developer and new contributor. I'd like to work on this issue - could you please assign it to me ?"

Anjali-yadav513 avatar Nov 05 '25 08:11 Anjali-yadav513

Hey folks. This repository is not being developed on anymore, as the Apps-Engine package now resides in the https://github.com/RocketChat/Rocket.Chat monorepo. We'd appreciate if you made your contributions there - no need for an official assignment of any sort :)

I'll archive the repo to prevent further confusion

d-gubert avatar Nov 05 '25 12:11 d-gubert