Rocket.Chat.Apps-engine
Rocket.Chat.Apps-engine copied to clipboard
Reintroduce Bundle Installation
What? :boat:
Reintroduces Bundle Installation support for the engine
Why? :thinking:
Due to impairment with the Rocket.Chat release cycle, the Bundle Installation logic (that included a breaking change for the app installation API) had to be removed from the package. This PR reintroduces that behavior
Links :earth_americas:
PS :eyes:
Codecov Report
Merging #191 (68342f8) into master (59541c4) will decrease coverage by
0.82%. The diff coverage is12.69%.
@@ Coverage Diff @@
## master #191 +/- ##
==========================================
- Coverage 57.46% 56.64% -0.83%
==========================================
Files 76 77 +1
Lines 2513 2560 +47
Branches 360 370 +10
==========================================
+ Hits 1444 1450 +6
- Misses 1069 1110 +41
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/server/compiler/AppCompiler.ts | 26.03% <ø> (ø) |
|
| src/server/AppManager.ts | 14.51% <4.34%> (-0.52%) |
:arrow_down: |
| src/server/compiler/AppPackageParser.ts | 16.82% <5.71%> (-4.98%) |
:arrow_down: |
| src/server/compiler/IParseZipResult.ts | 100.00% <100.00%> (ø) |
|
| src/server/compiler/index.ts | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 59541c4...68342f8. Read the comment docs.
I just realized this isn't even merged?
@geekgonecrazy we had to remove it since that problem we had with encrypting the app file. Work on bundles has stopped since then