Rocket.Chat.Android icon indicating copy to clipboard operation
Rocket.Chat.Android copied to clipboard

[NEW] Sending attachments should be done in background rather than showing loading

Open divyanshub024 opened this issue 7 years ago • 8 comments

divyanshub024 avatar Mar 20 '18 13:03 divyanshub024

What do you mean with "done in background"? Is it about the background thread? Could you elaborate your issue please?

philipbrito avatar Mar 20 '18 23:03 philipbrito

Yes, Its about the background thread. So when you upload a file it will show loading and after the loading, it will send the attachment. What I suggest is once you select a file to send it should update the UI and in the background thread you should upload it.

divyanshub024 avatar Mar 21 '18 06:03 divyanshub024

@divyanshub024 I'm not sure I followed the description of this issue... the upload is being done in a background thread. Can you explain better please?

rafaelks avatar Apr 03 '18 13:04 rafaelks

@rafaelks Yes, upload is being done in the background but its showing loading until its uploaded. It may be fine in good network connection but in poor network condition, you have to see loading for quite some time. So what I suggest is to show loading only on that image which is being uploaded rather than showing loading at the centre of screen.

divyanshub024 avatar Apr 06 '18 15:04 divyanshub024

@divyanshub024 I agree. I'm already working on it with a better upload feedback.

leonardoaramaki avatar Apr 06 '18 16:04 leonardoaramaki

any updates? Still if you for example rotate the screen upload aborts.

lorek123 avatar Feb 08 '19 22:02 lorek123

@leonardoaramaki any progress on this? I completely agree with @divyanshub024 . Beyond this we need guaranteed attachment delivery just like we have for messages. So when an attachment is uploaded by a user it is first stored locally. And then in the background we upload. A successful upload will be indicated graphically using changing checkmarks.

@filipedelimabrito @Shailesh351 @kb0304

bizzbyster avatar Aug 01 '19 14:08 bizzbyster

@bizzbyster No one is working on it currently but everyone is free to send us a PR.

philipbrito avatar Aug 01 '19 14:08 philipbrito