RC4Community icon indicating copy to clipboard operation
RC4Community copied to clipboard

[On Hold - Dec 22] Pre commit hooks

Open sidmohanty11 opened this issue 3 years ago • 4 comments

  • added necessary pre-commit hooks mentioned in the issue #49 under ./githooks
  • added a .pre-commit-config.yaml file where we can modify any configuration of the hooks
  • added a make script that shall be run to enable these hooks to run, ref: https://www.viget.com/articles/two-ways-to-share-git-hooks-with-your-team/
make enable-git-hooks

sidmohanty11 avatar Jan 25 '22 06:01 sidmohanty11

Why not use husky? Our main repo already uses it.

https://github.com/RocketChat/Rocket.Chat/blob/develop/.husky/pre-push

debdutdeb avatar Jan 25 '22 09:01 debdutdeb

@debdutdeb we could totally do that, I've added this according to the issue description but let me know if we want to use husky instead

sidmohanty11 avatar Jan 25 '22 12:01 sidmohanty11

Please focus your energy on the huge list of project contents TODOs instead of adding project infra elements.

Sing-Li avatar Jan 25 '22 15:01 Sing-Li

Sure!

sidmohanty11 avatar Jan 25 '22 16:01 sidmohanty11