RC4Community icon indicating copy to clipboard operation
RC4Community copied to clipboard

[Fix] brand logo link not redirecting to /

Open VenomFate-619 opened this issue 2 years ago • 5 comments

fixed Clicking on the rocket. chat brand logo does not redirect to the homepage Issue: #211

Before

https://user-images.githubusercontent.com/67755128/210505807-dc9bc0a7-f474-47ad-8aea-eb26392a5a1f.mp4

Now

https://user-images.githubusercontent.com/67755128/210504206-942b4dbe-da9b-436d-b018-412fe49c428b.mp4

VenomFate-619 avatar Jan 04 '23 07:01 VenomFate-619

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 04 '23 07:01 CLAassistant

gitpod-io[bot] avatar Jan 04 '23 07:01 gitpod-io[bot]

Hey @VenomFate-619 Thanks for the PR. The changes look good. However, sorry, but we can't merge it yet; you see, the changes are short, and it would be good if you could take on another issue and push the changes within this PR only, that will make it big.

Thank you!

Dnouv avatar Jan 04 '23 19:01 Dnouv

I found some more minor fixes like

  • The rocket chat logo in the footer not directing to rocket chat the main website
  • rocket chat in the menu bar of the mobile layout is doing a whole reload to get on the homepage instead it should be a client-side routing demo:-

https://user-images.githubusercontent.com/67755128/210494358-21d5abed-27d6-4b3e-8526-3a0f01409661.mp4

Should I also fix and push this in the same PR

VenomFate-619 avatar Jan 04 '23 19:01 VenomFate-619

Hey @VenomFate-619 Thanks for the PR. The changes look good. However, sorry, but we can't merge it yet; you see, the changes are short, and it would be good if you could take on another issue and push the changes within this PR only, that will make it big.

Thank you!

ok I will look for other issues

VenomFate-619 avatar Jan 04 '23 19:01 VenomFate-619