feat: Delete/File upload modal is now improved and Reaction emoji is added in message toolbar .
Brief Title
The Delete modal now follows RC’s standard labels and no longer displays actual content. The message toolbar shows a proper reaction emoji icon, and the file upload modal now includes validation to prevent empty submissions while improving accessibility. Additionally, usernames are now clickable, displaying user info, with an error fallback if the data cannot be fetched.
Acceptance Criteria fulfillment
- [x] improving Delete modal- removed showing actual content, and change some default labels to what RC follows
- [x] Add reaction emoji in message toolbar previously it is showing emoji icon
- [x] improve fileUpload modal - showing error if field is empty, fields are accessible through labels, does not send file if file-name is empty
- [x] Made username clickable showing userInfo and if does not able to fetch userInfo then show error.
Fixes #913
Video/Screenshots
https://github.com/user-attachments/assets/64ed3cb0-10cd-43c3-842f-221c4e38cc47
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-914 after approval. Contributors are requested to replace <pr_number> with the actual PR number.
Hello @thepiyush-303,
Has the behavior changed for all messages, or only for messages with attachments like audio, video, files, and images?
For normal text messages, the current delete modal works well by displaying the message content in the modal. However, for messages with attachments, it simply displays the attachment. We can improve this by showing the filename and file description along with the attachment.
This would give the user a clear understanding of which message they are deleting.
Currently, the following texts are displayed:
- Are you sure?
- You will not be able to recover this message! While both are based on RC terminology, they do not provide the user with a clear idea of which message they are actually deleting.
The approach mentioned above would certainly enhance the UI and improve the user experience.
I think we should follow Rocket's behaviour in EC also, rest will be decided by @Spiral-Memory
Hi @thepiyush-303 Make a detailed video of your changes showing all cases
@Spiral-Memory it will show the same modal for all types of messages.
https://github.com/user-attachments/assets/2ff46c97-a956-4e2b-afb7-7c55baed6ebe