EmbeddedChat icon indicating copy to clipboard operation
EmbeddedChat copied to clipboard

feat: Enhance Message Report modal and fix the logic of visibility of report option in toolbar

Open thepiyush-303 opened this issue 1 year ago • 4 comments

Brief Title

Acceptance Criteria fulfillment

  • [x] Enhance report/modal
  • [x] add logic for visibility
  • [x] include css

Fixes #904

Video/Screenshots

After:

https://github.com/user-attachments/assets/9d9af6f8-196e-445a-9b60-1c45573e63c8

Before:

https://github.com/user-attachments/assets/dcfe1e22-9872-4853-b90a-a0d6f56328db

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-907 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

thepiyush-303 avatar Jan 15 '25 16:01 thepiyush-303

Hi @thepiyush-303 Thanks for the PR! It looks good to me.

Just one minor change: could you remove the display of the message here?

image

If you decide to keep the message, there are several cases to handle:

  • The markdown should render correctly.
  • After a certain message length, it should truncate and display an ellipsis.

Spiral-Memory avatar Jan 27 '25 16:01 Spiral-Memory

Hey @Spiral-Memory I made the changes keeping RC's behavior in mind. I believe markdown will render the text perfectly. Regarding truncating the text, I will raise a new PR for it. or: If you want me to remove the actual message, please let me know what text should be displayed instead.

thepiyush-303 avatar Jan 27 '25 16:01 thepiyush-303

No need to raise another PR, Pls make the change here and let me know

Spiral-Memory avatar Jan 27 '25 16:01 Spiral-Memory

instead of truncating and adding ellipsis the behaviour for long text will look like this.

https://github.com/user-attachments/assets/ed4e3e6d-45d3-440b-b980-cc9c8ca6a765

is it ok @Spiral-Memory ?

thepiyush-303 avatar Jan 28 '25 13:01 thepiyush-303

@thepiyush-303 Lint check is failing

Spiral-Memory avatar May 24 '25 06:05 Spiral-Memory

Done @Spiral-Memory

thepiyush-303 avatar May 24 '25 07:05 thepiyush-303

Thanks @thepiyush-303 LGTM

Spiral-Memory avatar May 24 '25 11:05 Spiral-Memory