EmbeddedChat icon indicating copy to clipboard operation
EmbeddedChat copied to clipboard

Fix: Tool Tips positioned above for Message Toolbox

Open KrishnaShuk opened this issue 1 year ago • 5 comments

Tool-Tips positioned above Message Toolbox

Acceptance Criteria fulfillment

  • [x] The tooltip should be fully visible and display the complete text without being truncated.

Fixes #900

Video/Screenshots

Screencast from 2025-01-15 15-20-10.webm

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr- 901 after approval.

KrishnaShuk avatar Jan 15 '25 09:01 KrishnaShuk

Hello @KrishnaShuk, the tooltip arrow should point to the message toolbox, not the icon inside. If you want to change the position from bottom to top, please consider this point as well: Observe the current tooltip position, it's not directly on the icon.

dhairyashiil avatar Jan 15 '25 10:01 dhairyashiil

Will lift up the tooltip arrow that will point to the message toolbox. @dhairyashiil thanks for suggestion.

KrishnaShuk avatar Jan 15 '25 10:01 KrishnaShuk

Will lift up the tooltip arrow that will point to the message toolbox. @dhairyashiil thanks for suggestion.

Well, I have an idea. Instead of changing the position of the tooltip from bottom to top, you can change the positioning of the message toolbox by shifting it upwards. However, there's a catch: the message toolbar positioning differs for normal messages and quoted messages, so you need to ensure that the toolbar is usable for both types of messages.

dhairyashiil avatar Jan 15 '25 20:01 dhairyashiil

If you shift it to top, then the problem will again be the same when a message is at the top i believe, can we make it dynamic ?

Spiral-Memory avatar Jan 27 '25 16:01 Spiral-Memory

You are right @Spiral-Memory , will try to make it more dynamic.

KrishnaShuk avatar Feb 02 '25 12:02 KrishnaShuk