EmbeddedChat icon indicating copy to clipboard operation
EmbeddedChat copied to clipboard
verified publisher icon RocketChat

Warning of `using eval statements is highly discouraged` from the RC Node.js SDK

Open sidmohanty11 opened this issue 3 years ago • 3 comments

Description: The current Rocket.Chat Nodejs SDK has js-sha256 as its dependency which is showing the warning message.

Rocket.Chat Nodejs SDK v1.0.0-alpha.42

LINKED ISSUE IN RC Node.js SDK: issue

Steps to reproduce:

  1. npm run build and you will see it in the terminal

Expected behavior:

Not to show any warning message.

Actual behavior:

Shows a warning message.

image

sidmohanty11 avatar Jun 30 '22 16:06 sidmohanty11

Made a PR here, which will resolve this issue

sidmohanty11 avatar Jul 17 '22 15:07 sidmohanty11

This PR should be merged ASAP this eval error is annoying

iam-vipin avatar Jan 03 '23 07:01 iam-vipin

I want to contribute for this but I am not understanding what is the issue

kalyanram360 avatar Dec 24 '23 11:12 kalyanram360