Fix: getchannelavatarurl function in chatHeader and RoomInformation to Reflect Updated Avatar Changes.

Open AyushKumar123456789 opened this issue 1 year ago • 6 comments

Brief Title

Fix getChannelAvatarURL to Reflect Updated Avatar Changes in rocket.chat.

Acceptance Criteria fulfillment

[ ] Ensure updated avatars are displayed correctly after changes in Rocket.Chat.
[ ] Ensure getChannelAvatarURL function handles avatarETag correctly to fetch updated images.

Fixes #887

Video/Screenshots

https://github.com/user-attachments/assets/bfdf2a38-6322-48a7-8ac5-f19866e54971

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr_number> after approval. Contributors are requested to replace <pr_number> with the actual PR number.

Jan 13 '25 14:01 AyushKumar123456789

Looks like a great addition, @AyushKumar123456789 Thanks, Just want to make sure on few things

Jan 27 '25 16:01 Spiral-Memory

Hi @AyushKumar123456789 Can you please reply to the review comments

Feb 12 '25 13:02 Spiral-Memory

Sir, I think I have replied to the two comments you made 2 weeks ago, pardon me but I am not able to understand which comments there are any more than those two questions you are talking about

Feb 12 '25 13:02 AyushKumar123456789

Screenshot_2025-02-12-19-23-28-78_320a9a695de7cdce83ed5281148d6f19.jpg

Screenshot_2025-02-12-19-23-14-51_320a9a695de7cdce83ed5281148d6f19.jpg

Feb 12 '25 13:02 Spiral-Memory

I have replied to it; I don't know why this message did not reach you. Did I do something wrong?

Feb 12 '25 13:02 AyushKumar123456789

Sir, I'm looking forward to hearing back from you. Let me know if there is anything I can do.

Feb 12 '25 18:02 AyushKumar123456789