Feat: highlight search messages

Open dhairyashiil opened this issue 11 months ago • 3 comments

Brief Title

Highlight searched message text in rendered messages in Sidebar

Acceptance Criteria fulfillment

[X] Highlight all occurrences of the searched word in the sidebar messages, maintaining the original message text formatting.
[X] Ensure that the highlighting is removed when the search term is cleared or changed

Fixes #883

Video/Screenshots:

https://github.com/user-attachments/assets/e5cae978-f895-41e6-af91-1c660eabab89

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-884 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

Jan 12 '25 22:01 dhairyashiil

This is a great PR. Thanks for this @dhairyashiil

I think, you can optimize it further, Look into it, if you can reduce the amount of changes for this

Thanks

Jan 27 '25 16:01 Spiral-Memory

This is a great PR. Thanks for this @dhairyashiil

I think, you can optimize it further, Look into it, if you can reduce the amount of changes for this

Thanks

Thank you for the appreciation. I'm happy you liked it 😁, and yes, I will look into how I can optimize it further

Jan 28 '25 20:01 dhairyashiil

Have a look at this PR : https://github.com/RocketChat/EmbeddedChat/pull/937

She has done it in quite a few lines, though you've to see the optimization + stability

Jan 30 '25 19:01 Spiral-Memory