EmbeddedChat icon indicating copy to clipboard operation
EmbeddedChat copied to clipboard

fix: Added css to quote text properly.

Open thepiyush-303 opened this issue 1 year ago • 12 comments

Brief Title

now using > before any text will show separate quote, I use theme for putting color to maintain the coding standard.

Acceptance Criteria fulfillment

  • [x] Add css to quote text propely.

Fixes #840, #675

Video/Screenshots

image Screencast from 2025-01-11 16-24-32.webm

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-843 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

thepiyush-303 avatar Jan 08 '25 20:01 thepiyush-303

Fix the lint issue - Use prettier extension in your IDE and format it using prettier

Spiral-Memory avatar Jan 08 '25 21:01 Spiral-Memory

@Spiral-Memory Done.

thepiyush-303 avatar Jan 08 '25 21:01 thepiyush-303

Hey @Spiral-Memory, I think we can consider this fix to this issue #675 also by adding multiple blockquoting at once functionality. What do you think about?

devanshkansagra avatar Jan 09 '25 13:01 devanshkansagra

Hey @devanshkansagra, Do you want me to address #675 in this PR.

thepiyush-303 avatar Jan 11 '25 10:01 thepiyush-303

Yes, you can if you want to, currently I am researching upon something else, and hence this issue is not a priority at the moment, so you can address this also.

😊

devanshkansagra avatar Jan 11 '25 10:01 devanshkansagra

hence this issue is not a priority at the moment,

okay, can you tell the issue which are on priority so that i can also take a look on.

thepiyush-303 avatar Jan 11 '25 10:01 thepiyush-303

I meant that the issue I raised i.e. #675 and I am not working on that rn, this issue is kind of an inconsistency so you can fix this and add this pull request

Currently we are focusing on ui related enhancements to this project even more so you can research and work upon that too

There are no any specific issues to ui related enhancements so you can go through the project find any enhancements , if you find it and feels like it needs to get implemented then you are ready to go on 🚀

devanshkansagra avatar Jan 11 '25 11:01 devanshkansagra

Let me know once you add that fix here in this PR too @thepiyush-303

Spiral-Memory avatar Jan 11 '25 11:01 Spiral-Memory

Already done @Spiral-Memory My last commit address it.

thepiyush-303 avatar Jan 11 '25 11:01 thepiyush-303

Attach a video

Spiral-Memory avatar Jan 27 '25 17:01 Spiral-Memory

https://github.com/user-attachments/assets/3d67f531-9aac-4ff0-a80e-579bb9aa35d9

@Spiral-Memory There it is!

thepiyush-303 avatar Jan 27 '25 17:01 thepiyush-303

Hey @Spiral-Memory Please approve the changes.

thepiyush-303 avatar Apr 05 '25 07:04 thepiyush-303