EmbeddedChat icon indicating copy to clipboard operation
EmbeddedChat copied to clipboard
verified publisher icon RocketChat

fix: resolve mention highlighting issue for "application" and "text" file types and improve design

Open SinghaAnirban005 opened this issue 1 year ago • 4 comments

Brief Title

Mention Highlighting for "Application" and "Text" File Types and ensure design is consistent for files including collapse feature

Acceptance Criteria fulfillment

  • [x] Ensure mentioned usernames (@username) are properly highlighted for "application" and "text" file types.
  • [x] Update styling to handle mentions across all file types consistently.
  • [x] Add collapse feature

Fixes #828

Video/Screenshots

https://github.com/user-attachments/assets/decea07a-2abb-4631-8c8f-109f29a07d02

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-836 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

SinghaAnirban005 avatar Jan 08 '25 16:01 SinghaAnirban005

Can you please attach a video in all curve variant as well ?

Spiral-Memory avatar Jan 11 '25 10:01 Spiral-Memory

@Spiral-Memory here are the videos for the curve variant and also included the changes made in https://github.com/RocketChat/EmbeddedChat/pull/827#issuecomment-2585203938 in this PR

https://github.com/user-attachments/assets/4d475ba5-2b0a-4834-a1e5-f2c42c2670d9

SinghaAnirban005 avatar Jan 11 '25 13:01 SinghaAnirban005

image This is a quoted message originally, but being displayed as attachment

Please do testing on your side properly

image Also, Can we please align this

Spiral-Memory avatar Feb 09 '25 08:02 Spiral-Memory

After making changes ->

https://github.com/user-attachments/assets/dbc51991-ab54-40fc-9ced-f0bcb9bfbb19

SinghaAnirban005 avatar Feb 10 '25 17:02 SinghaAnirban005