EmbeddedChat icon indicating copy to clipboard operation
EmbeddedChat copied to clipboard

Enhance video recorder

Open dhairyashiil opened this issue 1 year ago • 6 comments

Brief Title

Acceptance Criteria fulfillment

  • [X] Make transitions smoother for starting, stopping, and sending the video, so users have a better flow when using the recorder.
  • [X] Update the interface with buttons for starting, stopping, and sending the video. The send button should be disabled until there’s a recording to send.
  • [X] Buttons change color according to the theme (light/dark mode).

Fixes #830

Video/Screenshots

https://github.com/user-attachments/assets/181c927c-b171-4899-af00-7f1c2566b74a

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-831 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

dhairyashiil avatar Jan 07 '25 23:01 dhairyashiil

Do we really need this much code changes for this ?

Spiral-Memory avatar Jan 11 '25 11:01 Spiral-Memory

Do we really need this much code changes for this ?

Yes, I have written a new function in 'useMediaRecorder.js'. The earlier functions were not supporting the current functionality I implemented. I wanted to completely remove those old functions, but currently, they are still used to record audio messages in 'AudioMessageRecorder.js'. Maybe after this PR gets merged, I will use the new function I wrote in this PR to record audio messages as well.

dhairyashiil avatar Jan 11 '25 12:01 dhairyashiil

@dhairyashiil Resolve the conflicts

Spiral-Memory avatar Jan 27 '25 17:01 Spiral-Memory

@dhairyashiil Resolve the conflicts

Done. Resolved the merge conflict.

dhairyashiil avatar Jan 29 '25 07:01 dhairyashiil

Still there

Spiral-Memory avatar Feb 09 '25 08:02 Spiral-Memory

Still there

Hello @Spiral-Memory , Resolved. Please check

dhairyashiil avatar Feb 09 '25 09:02 dhairyashiil