RocketChat
Fix: Highlight entire message body for 'Jump to Message' functionality
Brief Title
Fix: Highlight entire message body for 'Jump to Message' functionality
Acceptance Criteria fulfillment
- [X] The entire message body is highlighted when using the 'Jump to Message' functionality.
- [X] The highlight color is clearly visible in both light and dark themes.
Fixes #821
Video/Screenshots
Light theme:
https://github.com/user-attachments/assets/b8e8110d-fc05-46de-9728-5dcabcec7b3f
Dark theme:
https://github.com/user-attachments/assets/6353c022-4a75-4e9a-ae0c-a93ab89b3ef7
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-822 after approval. Contributors are requested to replace <pr_number> with the actual PR number.
Can we keep the color subtle ? This isn't looking good
But, yaa this is needed, thanks
Can we keep the color subtle ? This isn't looking good
But, yaa this is needed, thanks
Okay, understood. I'll do it. Thank you for the review.
Subtle shade: (Matched with RC)
https://github.com/user-attachments/assets/929b8c03-ced5-4ea5-b8e5-2f1bf4d1f8e3
Also, @Spiral-Memory, I think the current dark mode of the Default theme is too dark. We should make it less black and more greyish, just like RC. What do you think?
Also, @Spiral-Memory, I think the current dark mode of the Default theme is too dark. We should make it less black and more greyish, just like RC. What do you think?
Not needed, that is upto the developer who is setting it up, this is just for testing in storybook
In dark shade, it is still too yellowish, keep subtle there too. light looking good
Hello @Spiral-Memory , Make color subtle for Dark mode as well.
https://github.com/user-attachments/assets/13c1bf02-4059-4215-ab8c-17b213609dcc