RocketChat
feat: Enhance add link modal and disabling message items while typing
Brief Title
Enhance add link modal including proper css making it more user friendly, and when we write something it should disable items such as Audio recorder, video recorder and upload file option.
- also the blurriness of emojis are fixed in this PR by removing some css and majorly by not converting emojis in images instead directly send them in Html with their unicode, converting emojis to images is still done for emojis not containing unicode for e.g the emojis which are send to us from other side.
Acceptance Criteria fulfillment
- [x] Improving Add Link Modal - adding link icon, giving label
- [x] Disabling Audio/video/file options in toolbar while typing
- [x] pressing outside of the modal or clicking 'esc' should close the modal.
- [x] change the labels to what RC follows
- [x] fixing emoji blurring.
- [x] fix emoji handling logic.
Fixes #808
Video/Screenshots
https://github.com/user-attachments/assets/af568b1d-e611-4010-ae6c-48ac9cabfa66
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-809 after approval. Contributors are requested to replace <pr_number> with the actual PR number.
Please attach a video/screenshot of the Add Link modal as well.
It's already shown in the screencast attached above
Please attach a video/screenshot of the Add Link modal as well.
It's already shown in the screencast attached above
Got it. Can we remove the placeholders? Since you added labels, users will know what to type inside them.
Regarding the labels, since it's a Link Window and we're only interacting with the link (not any other functionality), users will understand that the 'Text' and 'URL' refer to the link. There's no need to specifically label them as 'Link Text' and 'Link URL'.
Also, I think it would be nice to stay consistent with Rocket.Chat channel terminology, using only 'Text' and 'URL'.
Hello @Spiral-Memory Let me know if blurriness of emojis is a valid issue .