RocketChat
Feat: Added 'Online User Status' Filter to Members List
Brief Title
Feat: Added 'Online User Status' Filter to Members List
Acceptance Criteria fulfillment
- [X] Added a filter dropdown to toggle between All and Online members.
- [X] By default, the filter is set to All, displaying all members.
- [X] When Online is selected, only online members are shown.
- [X] Ensured UI consistency with the Rocket.Chat member filter.
- [X] Ensured the filter is functional across all EmbeddedChat variants.
Fixes #781
Video/Screenshots
https://github.com/user-attachments/assets/643e1aa4-e3bd-433e-9766-493fd44a0a76
and
https://github.com/user-attachments/assets/f36eb088-1af0-47aa-918e-429fa8f11890
Admin View:
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-782 after approval. Contributors are requested to replace <pr_number> with the actual PR number.
Hey @dhairyashiil, I believe this feature might not be a priority for Embedded Chat at the moment. Since the online status of members is already indicated by the green dot over the circle, adding an extra filtering option for this seems redundant. What are your thoughts on this, @dhairyashiil, @Spiral-Memory?
Hey @dhairyashiil, I believe this feature might not be a priority for Embedded Chat at the moment. Since the online status of members is already indicated by the green dot over the circle, adding an extra filtering option for this seems redundant. What are your thoughts on this, @dhairyashiil, @Spiral-Memory?
Hello Smriti, I see your point, but I think this feature could still be useful in some situations:
-
What if there are many users? When there are a lot of people in the chat, this feature could help. If there are more than 10 or 20 people, being able to filter by online status will help users quickly find people who are available.
-
Search bar and filter together: The search bar and filter can work at the same time. This would make it easier to find active users, especially in bigger group chats.
-
Following Rocket.Chat’s idea: Since we usually follow Rocket.Chat's way of doing things, I thought this feature might work well here too. They added it, and it could be useful for us as well, especially in larger chats.
I agree that for small chats with just 1-10 people, it’s not needed, but when there are more members, it could really help.
Yeah, initially it felt like a useless option to me as well, but it does have its own use. and Since Rocket.Chat follows this idea, we’re good to integrate it into Embedded Chat as well.
Will review, @dhairyashiil .
Hello @Spiral-Memory and @smritidoneria, I have added the display count functionality as well. You can now find this in Rocket Chat. Above the member list, you will see the text 'Showing 6 of 6,' where 6 represents the count of members.
I believe the filter now makes even more sense. By selecting "Online" from the filter, you will see the total number of online users currently.
For reference, please see the screenshot (SS) of Rocket Chat.
. and The Embedded Chat's View after the recent commit:
https://github.com/user-attachments/assets/c27b4ecf-c73a-46ad-98e4-1de9e7a9c608
@Spiral-Memory, quick question:
If there are a total of 6 users in the room and 2 of them are online, should we show 'Showing 2 of 2' or 'Showing 2 of 6'?
Hello @Spiral-Memory, we haven't discussed this PR today. Please review it when you get a chance. Thank you.