EmbeddedChat icon indicating copy to clipboard operation
EmbeddedChat copied to clipboard

Fix quote markdown

Open devanshkansagra opened this issue 1 year ago • 12 comments

Fixed the quote markdown issue

Acceptance Criteria fulfillment

Now if you enter the message like this it won't create any issue

> I will not use abbrev.
>
> I will not use abbrev.
>
> I will not use abbrev.

Fixes #675

Video/Screenshots

image

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-676 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

devanshkansagra avatar Dec 01 '24 10:12 devanshkansagra

Hi @devanshkansagra I didn't really understand the issue, can you take some to explain it once.

Spiral-Memory avatar Dec 15 '24 10:12 Spiral-Memory

check this issue https://github.com/RocketChat/Rocket.Chat/issues/33493

devanshkansagra avatar Dec 15 '24 10:12 devanshkansagra

Not this one, the multiple quoting one and recursive quoting one

devanshkansagra avatar Dec 15 '24 10:12 devanshkansagra

#641

devanshkansagra avatar Dec 15 '24 10:12 devanshkansagra

Hi @devanshkansagra,

Blockquotes are typically used to highlight important notes or text. It would be better if you add a line as well. Additionally, blockquotes should support nesting.

Here’s an example for you. This will be rendered properly by GitHub:

> Hello  
> This is a blockquote.  
>> This is a nested blockquote.  

Hii

Hello
This is a blockquote.

This is a nested blockquote.

Hi

Spiral-Memory avatar Dec 15 '24 10:12 Spiral-Memory

Okay, will work on this highlighting and nesting the quotes

devanshkansagra avatar Dec 15 '24 10:12 devanshkansagra

Hey, can we implement this highlight thing by implementing a button in chatinput toolbar and on highlighting...users will able to highlight the thing they want to, if yes then I will add this addition in this pr

devanshkansagra avatar Dec 15 '24 10:12 devanshkansagra

Hey, can we implement this highlight thing by implementing a button in chatinput toolbar and on highlighting...users will able to highlight the thing they want to, if yes then I will add this addition in this pr

Not needed @devanshkansagra

Spiral-Memory avatar Dec 22 '24 09:12 Spiral-Memory

okk

devanshkansagra avatar Dec 22 '24 09:12 devanshkansagra

Let me know, once this is ready to review

Spiral-Memory avatar Jan 01 '25 13:01 Spiral-Memory

Hey @Spiral-Memory, it is not currently ready for review and also I am not currently working on this as I am busy in some other important stuffs which are even more important than this, Keep it open or I will draft it, I will make it ready for review when I will push the commit to this repo

devanshkansagra avatar Jan 01 '25 14:01 devanshkansagra

No no, I'm saying can you a show a video of how it's implemented on rc.. and how it can be useful for ec

Spiral-Memory avatar Jan 01 '25 14:01 Spiral-Memory