EmbeddedChat icon indicating copy to clipboard operation
EmbeddedChat copied to clipboard

Implemented workflow to deploy preview of pr changes

Open devanshkansagra opened this issue 1 year ago • 2 comments

Pull Request Preview Deployment to GitHub Pages

Acceptance Criteria fulfillment

  • [x] Deploy every pull request builds of monorepo to a unique url
  • [x] Remove Deployment when PR is merged and closed

Fixes #617

Video/Screenshots

image

devanshkansagra avatar Sep 04 '24 08:09 devanshkansagra

Hey @devanshkansagra Mark this PR as a draft until ready !!

Spiral-Memory avatar Sep 04 '24 08:09 Spiral-Memory

Hey, maintainers and @Spiral-Memory can you please review my pull request? If there are any changes to be made, I will follow up

devanshkansagra avatar Sep 14 '24 18:09 devanshkansagra

Hey @devanshkansagra Let me know the progress !

Spiral-Memory avatar Sep 25 '24 19:09 Spiral-Memory

Hey @Spiral-Memory, currently this PR is able to add and remove the pr deployments of react and ui-elements. Also I am researching about to deploy layout_editor and docs, which was not possible as we disscussed earlier. If I found the way I will update

devanshkansagra avatar Sep 26 '24 17:09 devanshkansagra

Sure, let me know once it's ready for review ! We do need docs and layout_editor deployment as well. Hope this new way works 🥹

Spiral-Memory avatar Sep 26 '24 17:09 Spiral-Memory

Okay sure I will let you know if the fix I found

devanshkansagra avatar Sep 26 '24 17:09 devanshkansagra

Check why deploy PR is failing

Spiral-Memory avatar Sep 30 '24 17:09 Spiral-Memory

Merging it for testing, will revert the change if it doesn't work

Spiral-Memory avatar Sep 30 '24 17:09 Spiral-Memory

Reverting the PR as it is not working for unmerged PRs

Spiral-Memory avatar Sep 30 '24 17:09 Spiral-Memory