RocketChat
[FEAT] Added support to deploy monorepos to github pages
Acceptance Criteria fulfillment
- [x] Deploy the monorepo to the github pages
Fixes #612
Video/Screenshots
Screencast from 2024-07-26 09-14-45.webm
LGTM! Let's wait for the layout editor and docs to be merged. Then we can add the docs and editor to the deployment as well.
Hey @devanshkansagra , I was going through your pr and I noticed that the deploy job in this workflow contains two actions/checkout steps. It seems redundant to check out the code twice when once should be sufficient. Could you please explain why both steps are necessary?
It's fantastic to see contributors reviewing each other's code, asking questions, and learning together! Keep up the great work and continue learning 🙏
Hey @smritidoneria, thank you for pointing out about those redundant lines. Yesterday I was researching from the fuselage repo, this-dot article, and ai, so those lines might be added during the research and I might didn't have noticed about that redundancy. I have removed that redundant line and pushing the code.
I have seprated build workflow and deploy workflow, because incase in future some error occured in the deploy action(deploy.yml), it will be easy to find out at which workflow the error has occured.
@devanshkansagra Layout editor has been added, you can now include that and docs in deployment
Hey @Spiral-Memory and maintainers, I have added the layout editor in the deploy workflow, can you please review it?
LGTM !
Can you once share me forked deploy URL for that ?
Hey @Spiral-Memory, I did not implemented in my forked repo, instead I have created another repo so that if something happens my fork does not break here's that repo url: https://github.com/devanshkansagra/EC
LGTM ! Can you once share me forked deploy URL for that ?
Hey @Spiral-Memory, I did not implemented in my forked repo, instead I have created another repo so that if somethings happens my fork does not break here's that repo url: https://github.com/devanshkansagra/EC
Hey, i am not asking for the repo URL, i am asking if you could share me the URL where layout-editor is hosted now ?
LGTM ! Can you once share me forked deploy URL for that ?
Hey @Spiral-Memory, I did not implemented in my forked repo, instead I have created another repo so that if somethings happens my fork does not break here's that repo url: https://github.com/devanshkansagra/EC
Hey, i am not asking for the repo URL, i am asking if you could share me the URL where layout-editor is hosted now ?
https://devanshkansagra.github.io/EC/layout_editor/ this one??
It's already in the docs folder now!
Figure out a way to host the .md files in the proper format, then add it to this PR.
Some good examples are Gitbook, Docsify, Mintlify, etc.
Hey, maintainers and @Spiral-Memory, can you review the changes of adding a docs site? So that I can follow up if any improvements needed.
Ensure that all links reference the documentation website and do not redirect to GitHub markdown files, unless absolutely necessary.
Ensure that all links reference the documentation website and do not redirect to GitHub markdown files, unless absolutely necessary.
You can verify it here: https://devanshkansagra.github.io/EC/docs/
LGTM, ready to merge!
Hey @sidmohanty11,
We might need repo settings access to configure a few things. Let's proceed with the merge and see if it works, or if we need repo settings permissions.