EmbeddedChat icon indicating copy to clipboard operation
EmbeddedChat copied to clipboard

fixed all markdown issues

Open smritidoneria opened this issue 1 year ago • 2 comments

Brief Title

Fixed all the message rendering issues.

Acceptance Criteria fulfillment

  • [ ] Task 1
  • [ ] Task 2
  • [ ] Task 3

Fixes #613

Video/Screenshots

https://github.com/user-attachments/assets/2f39a9ce-938c-4466-be29-a219728b1116

smritidoneria avatar Jul 25 '24 20:07 smritidoneria

@smritidoneria, Could you please check and share the result of strikethrough and other markdowns whether it is working or not when the quoted message is sent? When I saw your code, you have made no changes in attachment preview dir. So I think at that point there could be this small bug

devanshkansagra avatar Sep 22 '24 16:09 devanshkansagra

hey @devanshkansagra , thanks for pointing out, I will look after it

smritidoneria avatar Sep 23 '24 11:09 smritidoneria

Hey @smritidoneria Could you please resolve the conflicts?

Spiral-Memory avatar Oct 06 '24 08:10 Spiral-Memory

hey @Spiral-Memory , changes have been made to resolve the conflicts, kindly look at it.

smritidoneria avatar Oct 22 '24 14:10 smritidoneria

Format check is failing @smritidoneria

Spiral-Memory avatar Oct 26 '24 11:10 Spiral-Memory

hey @Spiral-Memory , Something is wrong with the built SyntaxError: Unexpected identifier 'assert' at compileSourceTextModule (node:internal/modules/esm/utils:337:16) at ModuleLoader.moduleStrategy (node:internal/modules/esm/translators:166:18) at callTranslator (node:internal/modules/esm/loader:416:14) at ModuleLoader.moduleProvider (node:internal/modules/esm/loader:422:30) at link (node:internal/modules/esm/module_job:88:21)

This error is coming,

I have ran prettier, installed babel for the Transpilation also , but it remains the same.

smritidoneria avatar Oct 28 '24 06:10 smritidoneria

Hey @smritidoneria,

It's working for all new PRs except yours. Could you please check if there's any issue with your setup?

If the problem still exists, I'll clone your code and investigate what might be causing it.

Spiral-Memory avatar Oct 28 '24 06:10 Spiral-Memory

can u re-run the checks, I have resolved the errors @Spiral-Memory

smritidoneria avatar Oct 28 '24 07:10 smritidoneria

Format check passed, lint check failing

Spiral-Memory avatar Oct 28 '24 08:10 Spiral-Memory

fixed.

smritidoneria avatar Oct 28 '24 08:10 smritidoneria

Can you please list all the places you fixed the markdown ? I need to verify

Spiral-Memory avatar Nov 02 '24 16:11 Spiral-Memory

while quoting messages and in the delete modal.

smritidoneria avatar Nov 06 '24 18:11 smritidoneria

hey @Spiral-Memory , resolved the changes that you have mentioned. kindly look into it.

smritidoneria avatar Dec 17 '24 07:12 smritidoneria