RocketChat
Show error toast message for failed login attempt.
The login modal should show a toast message with an appropriate message in case of login failure.
Hey @abhinavkrin Is this issue assigned particularly or we could make PRs independently
@abhinavkrin, Regarding the toast error when login fails, it is already present in the frontend code when the 'Unauthorized' tag is returned from the server. The reason it is not visible is that the Embeddedchat API is not returning the correct error tag. The issue is already addressed in my pull request, which you requested a review for: https://github.com/RocketChat/EmbeddedChat/pull/401. You can watch my uploaded video to see that this also works there just after correcting server response. The problems, such as the 2FA modal not opening and the login error not showing, are related to the server response, and I have handled all such issues in the pull request.
@abhinavkrin , See, in rcAuth on frontend, all of the logic is already written in the existing code, it is unable to show because server was not returning correct response that is needed on frontend. The PR i raised automatically solves many issues like of 2FA OTP entry, OTP invalid toast message, login failed toast message etc as it addresses the server response which is the root cause of this issue.
Hey @Akshun-01 @Yashraj7890, I request you to please wait until further confirmation from Abhinav before starting to work on this issue.