EmbeddedChat icon indicating copy to clipboard operation
EmbeddedChat copied to clipboard

Published 20 hours ago • verified publisher icon RocketChat

Remove css files

Open abhinavkrin opened this issue 1 year ago • 12 comments

We have now shifted to using emotion.sh for styling. The old CSS files needs to be replaced with emotion styling. There may be some unused CSS files that needs to be removed.

abhinavkrin avatar Sep 28 '23 18:09 abhinavkrin

I'd like to work on this issue. Please assign me

ShatilKhan avatar Sep 30 '23 15:09 ShatilKhan

Hey @ShatilKhan I have assigned this issue to you. Are you working one this?

abhinavkrin avatar Oct 01 '23 12:10 abhinavkrin

Hey @abhinavkrin i would like to work on this issue please assign this one to me.

Uj293 avatar Oct 03 '23 16:10 Uj293

@Uj293 I have assigned this issue to you.

abhinavkrin avatar Oct 03 '23 18:10 abhinavkrin

Hi @abhinavkrin , I'm working on this issue and will get back to you asap. Please assign this issue to me.

umangutkarsh avatar Oct 04 '23 13:10 umangutkarsh

Hi @abhinavkrin , I've removed the css files. Please review the PR and provide feedback if any modifications are required. Thanks.

umangutkarsh avatar Oct 04 '23 14:10 umangutkarsh

Hi @abhinavkrin There are many css files that are being imported and used in js. Do we've to remove that as well?

KushalSr avatar Oct 04 '23 16:10 KushalSr

Also, do we've to manually import css from emotion for those files?

KushalSr avatar Oct 04 '23 16:10 KushalSr

is this issue resolved..?? @umangutkarsh

Uj293 avatar Oct 04 '23 18:10 Uj293

@umangutkarsh Hi Utkarsh need your help in setting up dev environment Could you help me?

KushalSr avatar Oct 04 '23 19:10 KushalSr

@umangutkarsh Hi Utkarsh need your help in setting up dev environment Could you help me?

You can follow this - https://github.com/RocketChat/EmbeddedChat#development

umangutkarsh avatar Oct 05 '23 06:10 umangutkarsh

Hey @abhinavkrin . There are some bugs which need to be addressed in the above PR I made. Shall I work on those as those were left in between? Thanks

umangutkarsh avatar Oct 27 '23 07:10 umangutkarsh