EmbeddedChat icon indicating copy to clipboard operation
EmbeddedChat copied to clipboard

refactor(api): migrate from sdk to ddp-client

Open this-is-varunxyz opened this issue 4 months ago • 3 comments

#Brief Title

refactor(api): migrate from sdk to ddp-client Acceptance Criteria fulfillment

[x] Removed deprecated @rocket.chat/sdk dependency

[x] Added @rocket.chat/ddp-client and implemented EmbeddedChatApi connection logic

[x] Refactored real-time subscriptions (room messages, typing status, user activity) to use DDP

[x] Added dependency resolution for @rocket.chat/core-typings to fix build errors

Video/Screenshots

N/A - Internal API Refactor (No UI changes) #PR Test Details

Description: This PR migrates the core API logic from the deprecated SDK to the supported ddp-client. This ensures better long-term support and fixes dependency resolution issues.

How to Test:

Switch to this branch.

Run yarn install (Verified that resolutions in root package.json fixes the core-typings error).

Navigate to packages/api and run yarn build.

Verify that the build completes successfully and dist/index.js is generated.

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr_number> after approval. Contributors are requested to replace <pr_number> with the actual PR number.

this-is-varunxyz avatar Dec 17 '25 22:12 this-is-varunxyz

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Dec 17 '25 22:12 CLAassistant

@devanshkansagra Please look into this as you were working on this, See if you guys can collaborate on this.

Spiral-Memory avatar Jan 03 '26 06:01 Spiral-Memory

Hey @this-is-varunxyz, is this working properly on newer react versions?

devanshkansagra avatar Jan 03 '26 06:01 devanshkansagra