Apps.Github22 icon indicating copy to clipboard operation
Apps.Github22 copied to clipboard

Fix contribution graph image from /github me command

Open chinma-yyy opened this issue 2 years ago • 2 comments

Description:

When using the /github me command the user is prompted to share the contribution graph image but the contribution graph endpoint does not provide contribution graph image URL and hence the image block is always in loading state.

Steps to reproduce:

  1. Run the app locally
  2. Login through /github login
  3. Type /github me

Expected behavior:

Show user information with contribution graph image and

Actual behavior:

Contribution Graph image URL is not retrieved from the endpoint provided and the image is stuck in loading state

chinma-yyy avatar Feb 21 '23 09:02 chinma-yyy

Hey, @chinma-yyy . We are using github-readme-activity-graph project for having the github contribution graph and i have found out that the deployment for the project has been changed to https://github-readme-activity-graph.cyclic.app Thus, it always in loading state. Check here we have old deployment url: https://github.com/RocketChat/Apps.Github22/blob/main/github/helpers/githubActivityGraphURL.ts#L3 thats the thing we will need to change.

  • You can edit this issue for solving the actual issue. Thanks!

Nabhag8848 avatar Feb 21 '23 16:02 Nabhag8848

Yeah @Nabhag8848 , I noticed the old deployment url but couldnt find the new one. Thank you for the changes, i will update the issue and also solve the issue.

chinma-yyy avatar Feb 21 '23 17:02 chinma-yyy