[dressnpc_master] DressNPC - Upright Orcs

[DJScias]

Description:

Orc characters that use the upright posture have customDisplay3 = 1 (characters table) but setting feature3 = 1 doesn't make them upright for DressNPC.

Current behaviour:

Nothing happens, the orc remains non-upright if you set feature3 = 1.

Expected behaviour:

The DressNPC Orc uses the upright Orc model/skeleton/posture

Steps to reproduce the problem:

1. Create a character Orc and set their posture to upright. This will make customDisplay3 = 1 in the characters table.
2. Create a DressNPC Orc and set their feature3 = 1 and notice it doesn't emulate the same behaviour.

Branch(es):

dressnpcs_master

TC rev. hash/commit:

Any BFA commit that supports upright Orcs (8.0.1+), so latest hash: https://github.com/TrinityCore/TrinityCore/commit/d11b9a6992b9e46cc880f4c8b085479009acfaab

TDB version: TDB 7.3.5 (it's never been updated)

Operating system: Windows 10

[Rochet2]

Cant see anything special with upright orcs in core. They just dont seem to work with mirror image. So seems that something needs to be done with the mirror image packet maybe.

custom features work for other races (see blindfold in image, it is custom feature 3).

It seems that both models for orc use same modelid. When doing .morph 51 the white model does not seem to have the upright orc data though, as can be seen from the hair part of the model easily:

[DJScias]

I'm gonna guess that means DressNPC is just straight-out incompatible with upright orcs or is there something else that decides about this?

[Rochet2]

I have not found what it is that decides this or if dressnpcs is capable of this.

If blizzard is able to do it, then it should be possible in dressnpcs. But if there are no mage orcs with upright position that can cast mirror image so that the images are also upright then there is likely no way.

[hoxton22]

Hello, instead of creating new issue i'm gonna use this one, i noticed something with uprights orcs in bfa 8.3 (my actual rev : 5a6970e5564cb0b41a21208b165501bcff822189)

You can see upright orcs when you go away from them (more than 600 yards) and come back

Step to reproduce :

1. Create a DressNPC Orc and set their feature3 = 1 (race 2 or race 36)
2. Spawn the orc ingame (he is non-upright)

3. go away from him, (target him,when the target vanish, you can come back)

4. now he is upright (works with the maghar orc too)

That's weird, because the mirror image doesn't handle the upright pose, even on live realm

[Rochet2]

mirror image doesn't handle the upright pose, even on live realm

Interesting. I have not had enough time and motivation to install a client and go see.

You can see upright orcs when you go away from them (more than 600 yards) and come back

If that is the case, then its probably worth trying to look into if the features can somehow be applied earlier in creating a creature or potentially force sent/updated to client. I am unsure when I have time to look into this.

[hoxton22]

Np, this isn't a big issue 😄

Btw here is a screenshoot about the clone effect on live realm, this quest create a NPC based on your character, as you can see the clone isn't an upright orc