webpack-build-notifier
webpack-build-notifier copied to clipboard
RoccoC
fix: ignoreWarnings not working on webpack 5
if this PR isn't wanted im happy to maintain my own fork. 🙏
also im not 100% how to fix the error the tests are throwing. 🤔 if someone can point me in the right direction ill be happy to fix them up.
closes: https://github.com/RoccoC/webpack-build-notifier/issues/90 and https://github.com/RoccoC/webpack-build-notifier/issues/81
bump ⬆️
There's an issue when running npm test, but otherwise all looks good! Thanks again, and so sorry for the delay!
if tests need to pass before merging then a CI action should be added to enforce that.
i cannot get the tests to run locally. they just sit there without doing anything.
➜ webpack-build-notifier git:(master) ✗ npm run test -- --verbose
> [email protected] test
> jest --verbose
RUNS tests/test.spec.ts
i cannot get the tests to run locally. they just sit there without doing anything.
I'll get these fixed up and merged. Thanks for your PR.
if tests need to pass before merging then a CI action should be added to enforce that.
Thanks for flagging this. Looks like TravisCI was no longer working. I went ahead and migrated to CircleCI.
@RoccoC kinda an odd move to repush this as your own commit and wipe me from the authors...
@RoccoC kinda an odd move to repush this as your own commit and wipe me from the authors...
Ah crap, @ImLunaHey , this was completely unintentional. I had first merged your PR into a new branch so I could fix the test issues, but when I merged that branch into master I didn't consider that all the work would be misattributed to me. 🫤
Interestingly, the auto-generated release notes captured your contribution.
I apologize for messing this up. Let me see if I can amend the commit history.
Seems a bit unusual, generally if one rebases and rewrites history the "author" is retained, just committer changes. Think you'd probably need to rewrite history and force push on master to fix that for @ImLunaHey :-(
Think you'd probably need to rewrite history and force push on master to fix that
Exactly, thanks! 😄
@ImLunaHey , thanks again for the contribution, and apologies for my screw-up here
(Sorry I ended up here because I posted a stupid question about whether this broke Webpack 4 compat, but saw up above that it does so deleted my comment - also see the release notes were clarrified that Webpack 4 support/compat was dropped so thank you for that!)
Also thank you for putting in the effort to correct the contrib history here. It can seem like a small thing, but personally I feel these such small things are really important for the vibe/culture of OSS, especially now LLMs are laundering all our contributions everywhere else. It's a thankless task at the best of times! 😬
