Robert Müller

0.7 skin name array sizes are inconsistent, `protocol7::CNetObj_De_ClientInfo` too small

1

See https://github.com/ddnet/ddnet/pull/9116#issuecomment-2395213924. #9116 added `MAX_SKIN_LENGTH = 24` only for DDNet code because the array sizes of 0.7 skin (part) names are more inconsistent and seemingly broken with demos so this...

When using Ninja and MSYS2, the resource files cannot be compiled: ``` [1/5] Building RC object CMakeFiles/game-client.dir/other/icons/DDNet.rc.obj FAILED: CMakeFiles/game-client.dir/other/icons/DDNet.rc.obj X:\msys64\usr\bin\windres.exe -O coff -DCONF_AUTOUPDATE -DCONF_BACKEND_VULKAN -DCONF_GLEW_HAS_CONTEXT_INIT -DCONF_INFORM_UPDATE -DCONF_VIDEORECORDER -DGAME_RELEASE_VERSION=\"18.7\" -DGLEW_STATIC -DNOMINMAX...

Client/server crash when sending messages at and near maximum size

3

Sending a connection-oriented message from the client/server with size between `NET_MAX_PAYLOAD - 4` and `NET_MAX_PAYLOAD` crashes, both as a raw message and when using `CPacker` to pack the message. Sending...

Send list of all maps available in the `maps` folder on the server to authed clients, using version 18.7 or newer, that have access to the `sv_map` or `change_map` command,...

Server crash in `CGameContext::OnShutdown` using `hot_reload`

1

Reported by triki on Discord: ``` 0x00000001400c31b4: std::_Rb_tree::_M_erase(std::_Rb_tree_node*) at /usr/x86_64-w64-mingw32/include/c++/13.1.0/bits/stl_tree.h:1936 0x00000001400c31c0: std::_Vector_base::~_Vector_base() at /usr/x86_64-w64-mingw32/include/c++/13.1.0/bits/stl_vector.h:367 (inlined by) std::vector::~vector() at /usr/x86_64-w64-mingw32/include/c++/13.1.0/bits/stl_vector.h:733 (inlined by) std::pair::~pair() at /usr/x86_64-w64-mingw32/include/c++/13.1.0/bits/stl_pair.h:187 (inlined by) void std::__new_allocator::destroy(std::pair*) at /usr/x86_64-w64-mingw32/include/c++/13.1.0/bits/new_allocator.h:194...

When on a server, `GameClient()->m_Snap.m_SpecInfo.m_Active` is `true` when spectating and `false` when ingame. In the demo player, `GameClient()->m_Snap.m_SpecInfo.m_Active` is always `true` except when using "Follow" specating mode (which is the...

Remove `unbindall` command or make it less hazardous

5

Suggested by @sjrc6 on Discord: > should we even have the unbindall command? It seems like a hazard when you can just open the cfg file and delete the binds...

Servers rarely appear without gametype in the server browser

5

Reported by Pioooooo on Discord:  Refreshing the server browser fixes it. Maybe the server briefly registers with incomplete info.

We compile around 800 LOC on the server side that are mostly unused. This includes embedding the paths of all sounds and images as strings in the executable. AFAICT, only...

The confirmation popup was not shown for the Save As dialog anymore, due to the label being changed to `Save As` for the respective quick action. This check based on...