roslibjs icon indicating copy to clipboard operation
roslibjs copied to clipboard

Published 20 hours ago • verified publisher icon RobotWebTools

Add fail callback and missing docstrings to params

Open epaezrubio opened this issue 4 years ago • 4 comments

epaezrubio avatar Mar 20 '20 14:03 epaezrubio

I'm looking forward to some feedback about this PR 😃

epaezrubio avatar Aug 24 '20 22:08 epaezrubio

Looks good, tests are unhappy though.

mvollrath avatar Aug 25 '20 17:08 mvollrath

I'm unsure how to run the tests. If I have done it correctly, the tests pass in my machine. Moreover, how are the failed fibonacci tests related to these changes?

epaezrubio avatar Sep 01 '20 17:09 epaezrubio

This seems relevant: https://github.com/RobotWebTools/rosbridge_suite/issues/528

mvollrath avatar Sep 08 '20 16:09 mvollrath

@EzraBrooks @sea-bass I think this PR is worth reviewing.

MatthijsBurgh avatar Nov 16 '23 08:11 MatthijsBurgh

@EzraBrooks is this a breaking change? I need to know whether to include this change in the final v1 release.

MatthijsBurgh avatar Nov 28 '23 19:11 MatthijsBurgh

This is non-breaking, it only added an optional argument.

EzraBrooks avatar Nov 28 '23 21:11 EzraBrooks