ros-noetic icon indicating copy to clipboard operation
ros-noetic copied to clipboard

Add ecl

Open wolfv opened this issue 4 years ago • 3 comments

wolfv avatar Feb 24 '21 07:02 wolfv

See https://github.com/stonier/ecl_core/issues/111

Tobias-Fischer avatar Feb 25 '21 02:02 Tobias-Fischer

The Windows failure seems to be related to https://github.com/stonier/ecl_lite , not https://github.com/stonier/ecl_core . In particular, it seems that ECL_HAS_WIN_TIMERS is not defined at the preprocessor level and so the function is not defined: https://github.com/stonier/ecl_lite/blob/7f03e914d8aa6cb816f12b82e9b793d19c6ebe3c/ecl_time_lite/src/lib/date.cpp#L14 . As there is a #cmakedefine ECL_HAS_WIN_TIMERS in https://github.com/stonier/ecl_lite/blob/7f03e914d8aa6cb816f12b82e9b793d19c6ebe3c/ecl_time_lite/include/ecl/time_lite/config.hpp.in#L85 , probably it is sufficient to set ECL_HAS_WIN_TIMERS at the CMake level, if possible during the CMake invocation, or just by patching the CMakeLists.txt

traversaro avatar Feb 25 '21 08:02 traversaro

The macOS failure may be trickier, it seems that the related class is not enabled if we are on Apple, see https://github.com/stonier/ecl_core/blob/b8e8e10e0f5abfc63aeeac88000bacd0a85e1f9c/ecl_devices/include/ecl/devices/socket_client_pos.hpp#L22 .

traversaro avatar Feb 25 '21 08:02 traversaro

No one has asked for ecl in particular - closing

Tobias-Fischer avatar Nov 12 '23 23:11 Tobias-Fischer