Add add_definitions(-D__STDC_FORMAT_MACROS) to our catkin

[wolfv]

We could (globally) fix the problem with add_definitions(-D__STDC_FORMAT_MACROS) by adding it to our catkin patches so that it's set for all builds involving catkin under Linux.

[nberliner]

I've opened a PR for now to have the fix in the UR repo as you suggested (see #155). It would be great though if it would be possible to fix that globally.

Thanks again

[danzimmerman]

Do we understand why this doesn't seem to be an issue for the ordinary ROS distribution channels?

The ensuing discussion in https://github.com/UniversalRobots/Universal_Robots_ROS_Driver/pull/453 makes it seem like it's not necessary, but I definitely had to add this locally on a physical Ubuntu machine to get ur_calibration from the ROS2 Driver to build in my Robostack Humble environment.

I notice it's not in the ur_calibration patch now:

https://github.com/RoboStack/ros-humble/blob/main/patch/ros-humble-ur-calibration.patch

I see all the binaries are there (and I've installed that and checked it) Are you adding this definition globally now?

EDIT:

Also had to include it in the ur_client_library local build, along with the ros-humble-ur-client-library patch content.

[danzimmerman]

Do we understand why this doesn't seem to be an issue for the ordinary ROS distribution channels?

I see now in local vinca/boa work that that this seems to be specified globally in the recipe build scripts...

[Tobias-Fischer]

Indeed: https://github.com/RoboStack/vinca/blob/ae9e8fbbb7705925c289af372124ad621f295f6c/vinca/templates/build_catkin.sh.in#L51-L52

[wolfv]

I think that the idea was to add this to the catkin package, though, to enable it globally in all CMake scripts based on catkin @Tobias-Fischer

[wolfv]

(not just when using vinca & boa)

[Tobias-Fischer]

Ah I see ..