robosats
robosats copied to clipboard
Bug: "Existing orders match yours!" shows premium offers instead of discount
Describe the bug When creating a buy offer with a discount (e.g. -5%), after clicking "Create order" it shows "Existing orders match yours!" with premiums above "+5%".
You are shown matching orders if the following 4 conditions are true: 1- Order amount is within +-50% of the amount(s) of the existing order. 2- At least one of the payment methods coincides. 3- If selling, only buyers are shown. If buying, only sellers are show. 4- Same fiat currency.
It is not a bug if the premium of those orders are not a match to yours, in fact the premium is not part of the matchmaking algorithm. It is up to the user to discard the selection shown and proceed to "Create own order". Maybe this is however undesired behavior. We could think on adding an extra condition, e.g., if premium is not within "5%", or alternatively, if the premium is "cheaper than" (when buying) or "more expensive than..." (when selling).
Thanks for the clarification. "Existing orders match yours!" I understood to mean "you find a BETTER or equal deal for you already in existence, than you are trying to create" . That created the confusion on my side.