robosats icon indicating copy to clipboard operation
robosats copied to clipboard

ensure nostr pubkey is present in auth when creating robot

Open jerryfletcher21 opened this issue 6 months ago • 2 comments

What does this PR do?

Since nostr is becoming necessary for the trade process, this PR checks that the nostr_pubkey is present in the authorization header when creating a robot. It also documents the presence of nostr_pubkey in some comments.

Checklist before merging

  • [x] Install pre-commit and initialize it: pip install pre-commit, then pre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.

jerryfletcher21 avatar Jun 02 '25 16:06 jerryfletcher21

This change can't be possible while some folks run old frontend versions that are not sending nostr pubkey. Fortunately for us robodats clients always force users to upgrade if they detect a major new version on any of the coordinatros. That means these changes will only be possible with v0.8.0.

KoalaSat avatar Jun 02 '25 22:06 KoalaSat

@KoalaSat yes I understand. But it has been reported by other coordinators that there are now problems in sending the messages and completing the orders when nostr_pubkey is not present. It think it may be better to block the creation of robots all together and force them to update instead of allowing to create robots and not being able to complete the trades for old clients.

jerryfletcher21 avatar Jun 03 '25 07:06 jerryfletcher21