robosats icon indicating copy to clipboard operation
robosats copied to clipboard
verified publisher icon RoboSats

PR for desktop app

Open amitpanwar789 opened this issue 1 year ago • 18 comments

amitpanwar789 avatar May 25 '24 17:05 amitpanwar789

@KoalaSat have a look now .

amitpanwar789 avatar Jun 14 '24 15:06 amitpanwar789

https://github.com/RoboSats/robosats/pull/1299#discussion_r1640201233 i thought i only need to change for window.desktopApp ?

amitpanwar789 avatar Jun 15 '24 15:06 amitpanwar789

#1299 (comment) i thought i only need to change for window.desktopApp ?

I wad talking ahout the blank space, if you ran lint:fix, al good

KoalaSat avatar Jun 15 '24 17:06 KoalaSat

#1299 (comment) i thought i only need to change for window.desktopApp ?

I wad talking ahout the blank space, if you ran lint:fix, al good

I already run that don't know why it is there

amitpanwar789 avatar Jun 16 '24 04:06 amitpanwar789

Awesome job with /desktopApp! I just have one quick question, I see a lot of apparent duplication in tor/tor-*:

  • Are those README files necessary/different?
  • Are the files under /datadiferent per architecture? if not, maybe you can just move it up and use a symlink

which readme file

amitpanwar789 avatar Jun 16 '24 08:06 amitpanwar789

Awesome job with /desktopApp! I just have one quick question, I see a lot of apparent duplication in tor/tor-*:

  • Are those README files necessary/different?
  • Are the files under /datadiferent per architecture? if not, maybe you can just move it up and use a symlink

which readme file

For example desktopApp/tor/tor-linux/tor/pluggable_transports/README.CONJURE.md

KoalaSat avatar Jun 16 '24 11:06 KoalaSat

Awesome job with /desktopApp! I just have one quick question, I see a lot of apparent duplication in tor/tor-*:

  • Are those README files necessary/different?
  • Are the files under /datadiferent per architecture? if not, maybe you can just move it up and use a symlink

which readme file

For example desktopApp/tor/tor-linux/tor/pluggable_transports/README.CONJURE.md

Yes Readme are same in all three tor/

amitpanwar789 avatar Jun 16 '24 17:06 amitpanwar789

Awesome job with /desktopApp! I just have one quick question, I see a lot of apparent duplication in tor/tor-*:

  • Are those README files necessary/different?
  • Are the files under /datadiferent per architecture? if not, maybe you can just move it up and use a symlink

which readme file

For example desktopApp/tor/tor-linux/tor/pluggable_transports/README.CONJURE.md

Yes Readme are same in all three tor/

Then maybe we can move it up to the parent folder and avoid duplicated files

KoalaSat avatar Jun 16 '24 22:06 KoalaSat

All good now good job with the duplications, I wanted to test it but I realized I have no idea how to run it 😄 can you add a README.md file to /desktopApp with a some breve instructions?

KoalaSat avatar Jun 20 '24 07:06 KoalaSat

All good now good job with the duplications, I wanted to test it but I realized I have no idea how to run it 😄 can you add a README.md file to /desktopApp with a some breve instructions?

When I try to test it in windows and clone it in windows but the symlink is not working

amitpanwar789 avatar Jun 20 '24 12:06 amitpanwar789

@amitpanwar789 Tested on OSx and it looks great!! There is only one missing part on my opinion, did you configured the icon? image

KoalaSat avatar Jun 21 '24 09:06 KoalaSat

@amitpanwar789 Tested on OSx and it looks great!! There is only one missing part on my opinion, did you configured the icon? image

for icon we need to make the icon type .ico for window and .icns for mac to configure it correctly

amitpanwar789 avatar Jun 21 '24 12:06 amitpanwar789

@amitpanwar789 Tested on OSx and it looks great!! There is only one missing part on my opinion, did you configured the icon? image

for icon we need to make the icon type .ico for window and .icns for mac to configure it correctly

You can create then with this one https://github.com/RoboSats/robosats/blob/main/nodeapp/assets/icon/Robosats.svg

KoalaSat avatar Jun 21 '24 21:06 KoalaSat

@amitpanwar789 Tested on OSx and it looks great!! There is only one missing part on my opinion, did you configured the icon? image

for icon we need to make the icon type .ico for window and .icns for mac to configure it correctly

You can create then with this one https://github.com/RoboSats/robosats/blob/main/nodeapp/assets/icon/Robosats.svg

I have tested on linux and it working fine

amitpanwar789 avatar Jun 22 '24 12:06 amitpanwar789

should i make the separate pr for build part of add it in this pr

amitpanwar789 avatar Jul 10 '24 05:07 amitpanwar789

@KoalaSat i have a doubt and making build and uploading do we have to pre-release it as in android and then change release.yaml file download it as with android build

amitpanwar789 avatar Jul 21 '24 15:07 amitpanwar789

@KoalaSat i have a doubt and making build and uploading do we have to pre-release it as in android and then change release.yaml file download it as with android build

Desktop and Android app changes will be really in sync, so whatever process we are following in Android we should also folow it with Desktop :+1:

KoalaSat avatar Jul 21 '24 17:07 KoalaSat

@KoalaSat , i have added the configuration for release please have a look , i haven't tested it locally so i am not sure

amitpanwar789 avatar Jul 22 '24 08:07 amitpanwar789

Hey @amitpanwar789 thanks for the great effort! tested and approved :rocket:

KoalaSat avatar Sep 05 '24 19:09 KoalaSat