robocup-software icon indicating copy to clipboard operation
robocup-software copied to clipboard
verified publisher icon RoboJackets

[TODO] Make `hitSet` return an iterator

Open kylestach opened this issue 5 years ago • 0 comments

The Geometry2d library's hitSet currently incurs a lot of overhead by actually creating new smart pointers. We could save a lot of allocation and reference counting by just returning an iterator to it.

Code to change: https://github.com/RoboJackets/robocup-software/blob/staging/common/Geometry2d/ShapeSet.hpp#L50.

Example: https://github.com/RoboJackets/robocup-software/pull/1494/files/1d6b526aaeada2dc275fe30c3e2316de4e177dd9#diff-dfa0f461b7c683261fb993e66180bc72R39

Brought up in review on #1494.

kylestach avatar Jun 14 '20 06:06 kylestach