grSim
grSim copied to clipboard
Stop the robots when the stop receiving packages for 1 sec
Identify the Bug
Closes #166
Description of the Change
- Whenever a socket is received from
blueControlSocket
, theQElapsedTimer
elapsedLastPackageBlue
is restarted. - The function
MainWindow::update
will check every time it is called ifelapsedLastPackageBlue
has not been restarted for more than one second. If the condition is true, it will stop all blue robot. A similar/equivalent approach was made for theyellowControlSocket
.
Alternate Designs
Nothing.
Possible Drawbacks
- It does not turn the roller and the kick (I still did not find the proper way of doing so);
- I am still testing it.
Verification Process
Release Notes
Stop the robots when the stop receiving packages for 1 second
@mahi97 I tested it with a match test and I think this pull request is ready for review now.
One question, should I change something on the piece of code complained bu the CodeFactor?
@g3force this pull request is open for quite some time now... do I need to change anything before the pull request is merged?
@g3force what about now?
I've fixed the pipelines on master und updated your branch to see if everything is green.
Also, please use the GitHub review functions:
Press the cyclic arrows to rerequest review.
And please fix the CodeFactor issue. One method you modified is too complex now. Move code into a new method.