read json from response buffer instead of copying

Open polachok opened this issue 3 years ago • 3 comments

What problem are we solving?

mut and copy

How are we solving the problem?

removing mut and copy

Checks

Please check these off before promoting the pull request to non-draft status.

[ ] All CI checks are green.
[ ] I have reviewed the proposed changes myself.

Jul 04 '22 11:07 polachok

Thanks for this PR. Is it possible to add some tests for this?

Jul 15 '22 20:07 ChrisluRoblox

CLA Signature Action:

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:

I have read the CLA Document and I hereby sign the CLA

By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to our company's repositories.

0 out of 1 committers have signed the CLA. :x: @polachok

Jul 15 '22 20:07 github-actions[bot]

Hi @polachok thank you for this! Would you be willing to sign the CLA so we can accept this change?

Jun 18 '23 04:06 kushudai