Robin Picard

Results 62 comments of Robin Picard

> @RobinPicard are you still interested in implementing this? I can look at adapting it to the change made this week end

To make sure I understand the wider context, the plan is to eventually remove `SequenceGenerator` and only use `SequenceGeneratorAdapter` @lapp0, right? If so, should we implement it for both of...

I rebased on your branch and modified my initial commit @lapp0

This [issue](https://github.com/outlines-dev/outlines/issues/1048) is causing problems for the PR. If we don't have an explanation/solution for it, we would have to modify the logic related to `FSMLogitsProcessor._fsm_states`. I don't know yet...

It's fine if it only happens at the final generation step, I simply added a `try:... except KeyError:...` block

I don't have more questions, I would be interested by a review of the PR though!

I don't get how step 2 would work. Are the unhealed tokens passed down to the original Guide just the user prompt? Another design I'm considering for better separation of...

I think I understand the general idea. The main issue I have concerns > * If generating the final token in a path, pass the **unaligned** token to the child_guide...

Ah I see, but I thought the problem is that "rld" may not exist as a token in the vocabulary so it would not be found in the `states_to_tokens_map`. Or...

It seems to be because your json schema contains: ``` "type": "array", "items": {} ``` somewhere in it. An easy fix could to be to turn `if "items" in instance:`...