DarkUI icon indicating copy to clipboard operation
DarkUI copied to clipboard

Theme support added

Open solalem opened this issue 5 years ago • 4 comments

Dark and Light themes added

solalem avatar Jan 31 '20 08:01 solalem

Ooo very nice indeed.

ohhsodead avatar Feb 03 '20 19:02 ohhsodead

Some texts stay white and are not 100% readable but that can be fixed. This is awesome.

EthemAcar-Dev avatar May 03 '20 09:05 EthemAcar-Dev

I realise this is a very late comment - I've been meaning to fully review this PR for a while now but never had the time (and still do not have the time) to properly step through and test these changes.

As such, whilst I appreciate the amount of work that went in to this, I will not be merging this in.

DarkUI, .NET Framework 4.0, and WinForms are all legacy technologies at this point and should not be used when creating a brand new solution. Personally I use none of these, and no longer use Windows as my primary operating system.

Back in 2015/2016 I think this feature would have been a very strong selling point of DarkUI. However, in 2020 we're basically operating on life support. I'll continue to merge in bug fixes and minor improvements, but complete re-writes of core functionality are off the table.

I'll leave this PR open for anyone who wishes to pull down the changes made and run them locally, but I will not be deploying this to NuGet.

RobinPerris avatar Aug 08 '20 12:08 RobinPerris

... WinForms are all legacy technologies at this point and should not be used when creating a brand new solution.

Sorry about the bump, but I have to disagree with this. WinForms is still very much alive and is, in fact, seeing some love in .Net 5.0/6.0. I personally do not like XAML, so WPF and WinUI are a no-go for me.

Michael-Kelley avatar Jan 10 '21 20:01 Michael-Kelley