fix WSPeer

Open dacapoday opened this issue 3 years ago • 3 comments

whether WSPeer inherits from Peer as well as RTCPeer?

Jun 09 '22 03:06 dacapoday

What additional value does this PR bring? It seems the inheritance is not necessary as it works without it as well...

Jun 09 '22 07:06 fm-sys

What additional value does this PR bring? It seems the inheritance is not necessary as it works without it as well...

I think this is a very hidden problem when fallback to websocket send msg and it can be reproduced

Steps to reproduce

force snapdrop fallback to websocket by breakpoint and change window.isRtcSupported=false
then send msg and file failed and console raise error

This error means WSPeer not properly initialized. Its really only have _send method!!

Jun 09 '22 15:06 dacapoday

Ah, ok. Thanks for clarification and for helping to improve Snapdrop!

Jun 09 '22 16:06 fm-sys