snapdrop icon indicating copy to clipboard operation
snapdrop copied to clipboard

Implements issue #257

Open Bben01 opened this issue 4 years ago • 10 comments

The "Ask to save each file before downloading" is now saved in localStorage to persist after the session is ended.

Bben01 avatar Feb 24 '21 19:02 Bben01

And what if the user wants to take their selection back? Currently this can be done via refresh and I think we should implement an replacement for this. Maybe a bottom bar which displays "Auto download is currently enabled" with the action "disable" next to it?

fm-sys avatar Mar 10 '21 21:03 fm-sys

This is the same problem with dark mode options: at first it selects 'auto', but if you choose a preference, you can't change it back.

Bben01 avatar Mar 10 '21 21:03 Bben01

What do you think of this @RobinLinus? should we wait for an implementation of a 'reset' button or not? It closes #269 and #257

Bben01 avatar Mar 11 '21 07:03 Bben01

This is the same problem with dark mode options: at first it selects 'auto', but if you choose a preference, you can't change it back.

The only difference is that the automatic download of files in a public wifi network can be a big security risk, while the darkmode is "just an optical gimmick".

fm-sys avatar Mar 11 '21 09:03 fm-sys

Ok, I added an icon to indicate if the auto-download is on/off Snapdrop I could not test if receiving a file is working because I don't know how to do it.

Bben01 avatar Mar 12 '21 11:03 Bben01

I found a way to test it (open two different windows) and it works well

Bben01 avatar Mar 12 '21 11:03 Bben01

@RobinLinus Can you please merge this?

kokroo avatar Jun 10 '22 13:06 kokroo

@kokroo this branch has conflicts that needed to be solved.

victorwads avatar Jun 10 '22 13:06 victorwads

@victorwads I rebased the changes

Bben01 avatar Jun 11 '22 20:06 Bben01

@victorwads I rebased the changes

@RobinLinus @victorwads How about now?

kokroo avatar Jun 15 '22 15:06 kokroo