RobinLinus
Updated theme.js to resolve a bug
To resolve the bug #221 I added right click and long tap button support to reset theme to system preference. For now, this is a draft, because I want to wait others approvement.
@RobinLinus, what do you think about these changes?
@RobinLinus, what do you think about these changes?
Sorry that it took me so long to respond to your PR. This is a tough decision. I've been thinking about it quite a lot. To be honest, that's a lot of code for such a tiny flaw in Snapdrop's least important feature.
Furthermore, this is not DRY code. It repeats the logic of that "long tap" used to send messages to peers. The clean way here is to extract some generic "long tap" / "right click" function to register an event listener on elements similar to onclick or so.
Another question: How do we communicate this feature to users? Maybe that previous sketch using a dialog is better UX? I remember I said we should always minimize the number of clicks, but that makes sense only if users understand where to click...
Thank you @RobinLinus! I've revised all proposals of #221 and someone says also that it isn't a bug, because you choosed the theme and Snapdrop changes its default. For this I've thought about add a button on Snapdrop info to reset the theme to system. I'm not secure this is the correct way, but if we want to limit too much code and have a beatiful and simple solution, here is one example:
The button position can be changed in another position and the icon can be changed, if the current is not welcome. If this propose can't be a solution, there is this one, but can be a little hard to implement and requires much other lines of code:
